Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set code owner for all celery tasks #33179

Closed
4 tasks
timmc-edx opened this issue Sep 5, 2023 · 2 comments
Closed
4 tasks

Automatically set code owner for all celery tasks #33179

timmc-edx opened this issue Sep 5, 2023 · 2 comments
Assignees

Comments

@timmc-edx
Copy link
Contributor

timmc-edx commented Sep 5, 2023

Update: This didn't work, so we're updating the ADR to at least describe why we can't use this approach: openedx/edx-django-utils#345


We currently have to annotate individual Celery tasks with a decorator in order to get code-owner information. This causes Arch-BOM to get alerted sometimes due to missing decorators on new tasks. We've since learned of an alternative approach involving a signal, documented in ADR 3 of edx-django-utils.

@gautammd
Copy link

gautammd commented Sep 13, 2023

@timmc-edx can I have a go at this?

@timmc-edx
Copy link
Contributor Author

You can give it a try, but my experimental change in #33180 didn't work. I think New Relic opens the transaction after task_prerun and closes the task before task_postrun, so this signals-based approach probably doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants