Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: New React XBlock #511

Open
CodeWithEmad opened this issue Feb 14, 2025 · 5 comments
Open

Proposal: New React XBlock #511

CodeWithEmad opened this issue Feb 14, 2025 · 5 comments

Comments

@CodeWithEmad
Copy link
Member

CodeWithEmad commented Feb 14, 2025

Using React XBlocks is more common and there's not a single place in official documents explaining this. I suggest we create a new cookie-cutter to help folks have a faster/cleaner start.

@CodeWithEmad
Copy link
Member Author

@sarina @feanil, for this proposal, should I just go with the PR or does this need some sort of group decision?

@sarina
Copy link
Contributor

sarina commented Feb 14, 2025

This makes sense to me but I'd want to check in with @bradenmacdonald about his thoughts as I know he's been playing with react xblocks

@bradenmacdonald
Copy link

bradenmacdonald commented Feb 19, 2025

Everyone is in favor of this. Just know that it's already kind of been done twice, so don't duplicate the work! :p

I have created https://github.com/open-craft/xblock-react and would like to backport the changes to the cookiecutter. Since it's based on the cookie cutter, it should be easy to backport. The delay has been because in the meantime @xitij2000 also made a react based XBlock and did some things differently, including using Vite. I think some of what he did is nicer than what I did, so it would be good to combine the best features of both into the new cookie cutter and I simply haven't had time. Is this something you'd like to help with @CodeWithEmad ?

@CodeWithEmad
Copy link
Member Author

I wanted to add a simple React cookie-cutter like the one in opencraft's organization but the combination sounds good, If you guys don't have any plans to work on it, I'd like to give it a try.

@bradenmacdonald
Copy link

I won't be working on it for the next couple of weeks at least. So please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants