Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov fails on xblock #417

Closed
rgraber opened this issue Dec 6, 2023 · 5 comments
Closed

Codecov fails on xblock #417

rgraber opened this issue Dec 6, 2023 · 5 comments
Assignees

Comments

@rgraber
Copy link
Contributor

rgraber commented Dec 6, 2023

XBlocks made from the cookiecutter fail the codecov test. We should either fix it or remove it.
This ticket was spun out of #411

@robrap
Copy link
Contributor

robrap commented Dec 6, 2023

Tim noted that all our templates (not just XBlock), use the same codecov setup. Is the issue more widespread? Also, can we add more details to this ticket directly regarding what is actually failing?

@Talha-Rizwan
Copy link

Below are some test failing codecov logs i experienced with my xblock.

Run tox
pii_check create: /home/runner/work/test-xblock/test-xblock/.tox/pii_check
pii_check installdeps: -r/home/runner/work/test-xblock/test-xblock/requirements/test.txt
pii_check installed: appdirs==1.4.4,asgiref==3.7.2,backports.zoneinfo==0.2.1,boto3==1.29.6,botocore==1.32.6,click==[8](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713251#step:6:9).1.7,code-annotations==1.5.0,coverage==7.3.2,Django==4.2.8,django-appconf==1.0.6,django-statici18n==2.4.0,edx-i18n-tools==1.3.0,exceptiongroup==1.2.0,fs==2.4.16,fs-s3fs==1.1.1,iniconfig==2.0.0,Jinja2==3.1.2,jmespath==1.0.1,lazy==1.6,lxml==4.[9](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713251#step:6:10).3,Mako==1.3.0,MarkupSafe==2.1.3,openedx-django-pyfs==3.4.0,packaging==23.2,path==16.7.1,pbr==6.0.0,pluggy==1.3.0,polib==1.2.0,pytest==7.4.3,pytest-cov==4.1.0,pytest-django==4.7.0,python-dateutil==2.8.2,python-slugify==8.0.1,pytz==2023.3.post1,PyYAML==6.0.1,s3transfer==0.7.0,simplejson==3.19.2,six==1.16.0,sqlparse==0.4.4,stevedore==5.1.0,text-unidecode==1.3,tomli==2.0.1,typing_extensions==4.8.0,urllib3==1.26.18,web-fragments==2.1.0,WebOb==1.8.7,XBlock==1.8.1,xblock-utils==4.0.0
pii_check run-test-pre: PYTHONHASHSEED='3150130177'
pii_check run-test: commands[0] | code_annotations django_find_annotations --config_file .pii_annotations.yml --lint --report --coverage
Usage: code_annotations django_find_annotations [OPTIONS]
Try 'code_annotations django_find_annotations --help' for help.

Error: Invalid value for '--config_file': File '.pii_annotations.yml' does not exist.
ERROR: InvocationError for command /home/runner/work/test-xblock/test-xblock/.tox/pii_check/bin/code_annotations django_find_annotations --config_file .pii_annotations.yml --lint --report --coverage (exited with code 2)
___________________________________ summary ____________________________________
ERROR:   pii_check: commands failed
Error: The operation was canceled.

Run codecov/codecov-action@v3
==> linux OS detected
https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
==> SHASUM file signed by key id [8](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:9)06bb28aed77[9](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:10)869
==> Uploader SHASUM verified (b9282b8b43eef83f722646d8992c4dd36563046afe0806722184e7e9923a6d7b  codecov)
==> Running version latest
==> Running version v0.7.1
/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov -n  -Q github-action-3.1.4 -Z -F unittests
[2023-[12](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:13)-05T07:26:19.0[16](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:17)Z] ['info'] 
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.7.1
[2023-12-05T07:26:[19](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:20).024Z] ['info'] => Project root located at: /home/runner/work/test-xblock/test-xblock
[[20](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:21)[23](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:24)-12-05T07:26:19.029Z] ['info'] -> No token specified or token is empty
[2023-12-05T07:26:19.037Z] ['info'] Searching for coverage files...
[2023-12-05T07:26:19.092Z] ['info'] Warning: Some files located via search were excluded from upload.
[2023-12-05T07:26:19.092Z] ['info'] If Codecov did not locate your files, please review https://docs.codecov.com/docs/supported-report-formats
[2023-12-05T07:26:19.093Z] ['error'] There was an error running the uploader: No coverage files located, please try use `-f`, or change the project root with `-R`
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code [25](https://github.com/Talha-Rizwan/test-xblock/actions/runs/7097499222/job/19317713398#step:7:26)5

@rgraber rgraber self-assigned this Dec 13, 2023
@rgraber
Copy link
Contributor Author

rgraber commented Dec 13, 2023

Looks like several checks are actually failing. I'm going to see if it makes sense to fix them all at once or spin out more tickets.

@rgraber
Copy link
Contributor Author

rgraber commented Dec 15, 2023

#426 should fix the codecov problem. It's a little hard to test locally but it t least gets past the 'No coverage files located' error

@rgraber
Copy link
Contributor Author

rgraber commented Dec 21, 2023

Closing this issue in favor of the DEPR ticket for codecov: #429

@rgraber rgraber closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants