From b57271d8b1761fdf2ec51df03de88bdb39417ba7 Mon Sep 17 00:00:00 2001 From: Deborah Kaplan Date: Thu, 31 Aug 2023 21:02:45 +0000 Subject: [PATCH] feat: test specification * To verify that the test is catching the right thing, check the actual log message FIXES: APER-718 --- credentials/apps/records/tests/test_utils.py | 5 +++-- credentials/apps/records/utils.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/credentials/apps/records/tests/test_utils.py b/credentials/apps/records/tests/test_utils.py index 5e56fac15..691b6c6a0 100644 --- a/credentials/apps/records/tests/test_utils.py +++ b/credentials/apps/records/tests/test_utils.py @@ -1,5 +1,5 @@ -from logging import INFO import urllib +from logging import INFO from django.contrib.contenttypes.models import ContentType from django.core import mail @@ -86,8 +86,9 @@ def test_skip_if_user_has_no_program_certificate(self): # remover the fixture ProgramCertRecord ProgramCertRecord.objects.get(program=self.program, user=self.user).delete() - with self.assertLogs(level=INFO): + with self.assertLogs(level=INFO) as cm: send_updated_emails_for_program(self.request, self.USERNAME, self.pc) + self.assertRegex(cm.output[0], r".*ProgramCertRecord for user_uuid .*, program_uuid .* does not exist") # Check no other email was sent self.assertEqual(0, len(mail.outbox)) diff --git a/credentials/apps/records/utils.py b/credentials/apps/records/utils.py index 3f484cb48..50a5a44f1 100644 --- a/credentials/apps/records/utils.py +++ b/credentials/apps/records/utils.py @@ -43,7 +43,7 @@ def send_updated_emails_for_program(request, username, program_certificate): try: pcr = ProgramCertRecord.objects.get(program=program, user=user) except ProgramCertRecord.DoesNotExist: - logger.info("Program Cert Record for user_uuid %s, program_uuid %s does not exist", user.id, program.uuid) + logger.info("ProgramCertRecord for user_uuid %s, program_uuid %s does not exist", user.id, program.uuid) return # Send emails for those already marked as "SENT"