Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: freeform area width and responsive #44

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ihor-romaniuk
Copy link
Contributor

Description

This pull request contains minor fixes of width and responsive to feedback freeform area.

Screenshots

Before After
image image
Before After
image image

@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3eababa) 90.78% compared to head (8a56169) 90.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files           1        1           
  Lines         141      141           
=======================================
  Hits          128      128           
  Misses         13       13           
Flag Coverage Δ
unittests 90.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 20, 2023
@mphilbrick211
Copy link

Hi @openedx/arbi-bom! Is this something you could help review / merge for us? Thanks!

@farhan
Copy link
Contributor

farhan commented Dec 1, 2023

@ihor-romaniuk Please rebase PR with latest master

@farhan
Copy link
Contributor

farhan commented Dec 6, 2023

@ihor-romaniuk Please rebase the PR with latest repo master
Should I merge it?
I have approved it

@ihor-romaniuk
Copy link
Contributor Author

Hi @farhan. This PR is up-to-date and ready for merge. Thanks!

@farhan farhan merged commit 2a629d1 into openedx:master Dec 14, 2023
6 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the fix/feedback-freeform-area-width branch January 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants