feat: xblock aside #31
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
| #vote_aggregate = List( | ||
| # default=None, scope=Scope.user_state, | ||
| # help=_("A list of user votes") | ||
| #) |
There was a problem hiding this comment.
The scope user_state_summary is not compatible with the XBlockAside as the fields are not cached.
This is because the fields are behind a write through cache that is not prefetch correctly due to incorrect implementations in edx-platform. More context here: openedx/edx-platform#33554
| #self.runtime.publish(self, | ||
| # 'edx.feedbackxblock.likert_provided', | ||
| # {'old_vote': self.user_vote, | ||
| # 'new_vote': data['vote']}) |
There was a problem hiding this comment.
This can be updated in the base xblock to try - except this
|
Hi @feanil. I was planning to create a new model to store the data of only the aside data by adding a new context variable in the Another option would be to add support for XBlock Fields in XBlockAsides, but that seems to a be a large contribution |
|
@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@Ian2012 did you mean to close this? |
|
Yes, for now, this work will remain incomplete. However, I would like to know what are your thoughts on this. |
|
I'm not opposed to having the feedback xblock be an aside, I think I was trying to understand how it would affect all the other blocks and was having trouble visualizing where we would see it. |
|
This work would require a refactor in the CSS so that it will be hidden behind a modal for every other xBlock unless it's the feedback xBlock itselft. Another thing to keep in mind is that it will only be applied to the Vertical components (units), so not much of the content will be modified |
Description
This PR is an exploration / base implementation on creating an FeedbackXBlockAside.