The ODH operator deployment should use non-overlapping label selector

[astefanutti]

Describe the bug

The operator deployment is configured with the default label selector, as generated by the kubebuilder scaffolding, i.e.:

spec:
  selector:
    matchLabels:
      control-plane: controller-manager

This selector can intersect with other deployments, for instance the CodeFlare operator, which leads to issues where selection based on this selector returns more than expected.

To Reproduce

Steps to reproduce the behavior:

1. Install the Open Data Hub operator
2. Install the CodeFlare operator
3. Go to the Open Data Hub operator deployment details page > Pods tab

Expected behavior

Pods other than that of the ODH operator are listed.

Screenshots

Additional context

This also affect the metrics service pod selections:

The selector should be changed, so it's disjunct from any other deployments, ideally following Kubernetes recommended labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

The main challenge is that deployment label selector is immutable once created, which will break the rollout deployment performed during the next OLM upgrade: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates. With some more background available at kubernetes/kubernetes#50808.

A possible work-around is to renamed the operator deployment, according to OLM recommendation: operator-framework/operator-lifecycle-manager#952 (comment).

[zdtsw]

@astefanutti is this still a valid issue?

[astefanutti]

@zdtsw I think so yes. The operator still uses the default control-plane: controller-manager label selector.

[zdtsw]

@zdtsw I think so yes. The operator still uses the default control-plane: controller-manager label selector.

thanks! got confused when checking the description of "how to reproduce".

[astefanutti]

thanks! got confused when checking the description of "how to reproduce".

Ah yes, the description is out-dated now with v2, and we fixed it on the CodeFlare operator side, still it'd be valuable the ODH operator fixes it, as chances are the default label selector can intersect with other deployments / pods.

[AjayJagan]

here is the JIRA counterpart for the same issue : https://issues.redhat.com/browse/RHOAIENG-405