From f25139a098cbd6720eefc3aeea015ca01afb1291 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Hern=C3=A1ndez?= Date: Mon, 16 Dec 2024 14:21:18 -0600 Subject: [PATCH] Apply suggestions from code review: Filippe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Filippe Spolti Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> --- config/certmanager/certificate.yaml | 2 +- config/crd/kustomizeconfig.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/certmanager/certificate.yaml b/config/certmanager/certificate.yaml index b9e30b22..d13f9e33 100644 --- a/config/certmanager/certificate.yaml +++ b/config/certmanager/certificate.yaml @@ -25,7 +25,7 @@ metadata: name: serving-cert # this name should match the one appeared in kustomizeconfig.yaml namespace: system spec: - # SERVICE_NAME and SERVICE_NAMESPACE will be substituted by kustomize + # SERVICE_NAME and SERVICE_NAMESPACE will be replaced by kustomize dnsNames: - SERVICE_NAME.SERVICE_NAMESPACE.svc - SERVICE_NAME.SERVICE_NAMESPACE.svc.cluster.local diff --git a/config/crd/kustomizeconfig.yaml b/config/crd/kustomizeconfig.yaml index ec5c150a..fd57a0e6 100644 --- a/config/crd/kustomizeconfig.yaml +++ b/config/crd/kustomizeconfig.yaml @@ -1,4 +1,4 @@ -# This file is for teaching kustomize how to substitute name and namespace reference in CRD +# This file is for teaching kustomize how to replace name and namespace references in CRD nameReference: - kind: Service version: v1