Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ModelMesh Upgrade to v0.11 #186

Closed
3 tasks done
heyselbi opened this issue Sep 14, 2023 · 6 comments
Closed
3 tasks done

Test ModelMesh Upgrade to v0.11 #186

heyselbi opened this issue Sep 14, 2023 · 6 comments
Assignees

Comments

@heyselbi
Copy link

heyselbi commented Sep 14, 2023

Once the upgrade to v0.11 happens, we need to test:

  • Sample model deployment quickstart
  • Sample Model Deployment and Autoscaler quickstart
  • Sample Model Deployment by using a Persistent Volume Claim quikstart
@heyselbi heyselbi converted this from a draft issue Sep 14, 2023
@heyselbi heyselbi moved this from New/Backlog to To-do/Groomed in ODH Model Serving Planning Sep 14, 2023
@heyselbi heyselbi moved this from To-do/Groomed to In Progress in ODH Model Serving Planning Sep 20, 2023
@heyselbi
Copy link
Author

heyselbi commented Sep 21, 2023

Sample model deployment quickstart is successful with the upgrade

Image

@heyselbi
Copy link
Author

PVC test is successful:

[selbi@fedora pvc]$ export MODEL_NAME=isvc-pvc-storage-path
[selbi@fedora pvc]$ export HOST_URL=$(oc get route ${MODEL_NAME} -ojsonpath='{.spec.host}' -n ${TEST_MM_NS})
[selbi@fedora pvc]$ export HOST_PATH=$(oc get route ${MODEL_NAME}  -ojsonpath='{.spec.path}' -n ${TEST_MM_NS})
[selbi@fedora pvc]$ curl   --silent --location --fail --show-error --insecure https://${HOST_URL}${HOST_PATH}/infer -d  @../common_manifests/input-sklean.json

{"model_name":"isvc-pvc-storage-path__isvc-5157aa043b","outputs":[{"name":"predict","datatype":"INT64","shape":[1,1],"data":[8]}]}

[selbi@fedora pvc]$ export MODEL_NAME=isvc-pvc-storage-uri  export MODEL_NAME=isvc-pvc-storage-uri
[selbi@fedora pvc]$ export HOST_URL=$(oc get route ${MODEL_NAME} -ojsonpath='{.spec.host}' -n ${TEST_MM_NS})
export HOST_PATH=$(oc get route ${MODEL_NAME}  -ojsonpath='{.spec.path}' -n ${TEST_MM_NS})
[selbi@fedora pvc]$ curl   --silent --location --fail --show-error --insecure https://${HOST_URL}${HOST_PATH}/infer -d @../common_manifests/input-sklean.json 
{"model_name":"isvc-pvc-storage-uri__isvc-5157aa043b","outputs":[{"name":"predict","datatype":"INT64","shape":[1,1],"data":[8]}]}

@heyselbi
Copy link
Author

HPA and gRPC tests are successful

[selbi@fedora hpa]$ export HOST_URL=$(oc get route example-onnx-mnist -ojsonpath='{.spec.host}' -n ${TEST_MM_NS})
export HOST_PATH=$(oc get route example-onnx-mnist  -ojsonpath='{.spec.path}' -n ${TEST_MM_NS})
[selbi@fedora hpa]$ curl   --silent --location --fail --show-error --insecure https://${HOST_URL}${HOST_PATH}/infer -d @../common_manifests/input-onnx.json 
{"model_name":"example-onnx-mnist__isvc-b29c3d91f3","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}
[selbi@fedora hpa]$ oc port-forward --address 0.0.0.0 service/modelmesh-serving 8033 -n ${TEST_MM_NS}
Forwarding from 0.0.0.0:8033 -> 8033
Handling connection for 8033
^C[selbi@fedora hpa]$ oc get hpa
NAME                         REFERENCE                               TARGETS         MINPODS   MAXPODS   REPLICAS   AGE
modelmesh-serving-ovms-1.x   Deployment/modelmesh-serving-ovms-1.x   <unknown>/80%   1         1         1          3m15s
[selbi@fedora hpa]$ oc annotate servingruntime ovms-1.x serving.kserve.io/max-scale=3
servingruntime.serving.kserve.io/ovms-1.x annotated
[selbi@fedora hpa]$ oc annotate servingruntime ovms-1.x serving.kserve.io/min-scale=2
servingruntime.serving.kserve.io/ovms-1.x annotated
[selbi@fedora hpa]$  oc annotate servingruntime ovms-1.x  serving.kserve.io/targetUtilizationPercentage=50
servingruntime.serving.kserve.io/ovms-1.x annotated
[selbi@fedora hpa]$ oc get hpa
NAME                         REFERENCE                               TARGETS         MINPODS   MAXPODS   REPLICAS   AGE
modelmesh-serving-ovms-1.x   Deployment/modelmesh-serving-ovms-1.x   <unknown>/50%   2         3         1          5m45s

Observing the scaling up pods from 1 to 2 as well.

@Jooho
Copy link

Jooho commented Sep 21, 2023

live builder has some issues with building a new image now. QE team will do upgrade testing so we can skip the upgrade test this time.

@heyselbi
Copy link
Author

Last test is successful with specific conditions. See follow up ticket.

@heyselbi
Copy link
Author

Follow up dev ticket: opendatahub-io/opendatahub-operator#573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Status: Done
Development

No branches or pull requests

3 participants