Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Kserve's python image uid for ODH #13

Closed
skonto opened this issue Jun 26, 2023 · 4 comments
Closed

Adjust Kserve's python image uid for ODH #13

skonto opened this issue Jun 26, 2023 · 4 comments
Labels
good first issue Good for newcomers kind/feature New feature odh-release/1.8 Need to do for ODH Release v1.8.0

Comments

@skonto
Copy link

skonto commented Jun 26, 2023

/kind feature

Describe the solution you'd like
The uid needs to change for python images to something compatible for ODH.
Right now kserve needs to run with uid 1000 for python images because it creates files that have permissions based on that id.
This needs to change as now the user needs to allow uid 1000 on OCP, the latter requires a special scc.
See discussion opendatahub-io/odh-manifests#838 (comment) for more.

Anything else you would like to add:
N/A

@skonto
Copy link
Author

skonto commented Jun 26, 2023

cc @danielezonca

@heyselbi heyselbi added the kind/feature New feature label Jul 10, 2023
@heyselbi heyselbi moved this from Backlog to To-do This Sprint in ODH Model Serving Planning Jul 11, 2023
@danielezonca
Copy link

@ReToCode @skonto
Can you please confirm if this task is still necessary? I lost a bit track of the changes related with the anyuid issue.

My understanding was that it is necessary to fix how the user in these Dockerfiles
https://github.com/kserve/kserve/tree/master/python
is configured.

Note: we are disabling some of the features in KServe because we don't need to support them at this stage (see https://github.com/opendatahub-io/odh-manifests/issues/885) so this limit the scope of this ticket too.

FYI @israel-hdez

@heyselbi heyselbi added the odh-release/1.8 Need to do for ODH Release v1.8.0 label Jul 19, 2023
@ReToCode
Copy link

I don't think it is as you do not target/support those runtimes, rigth?

But, it would be if you want to support the runtimes that KServe has. KServe runtimes run as uid=1000 which will not work on OCP without anyuid. But images can be rebuilt with another use if necessary.

@Xaenalt Xaenalt added the good first issue Good for newcomers label Jul 25, 2023
@israel-hdez
Copy link

Reducing priority to minor, and ejecting from Sprint.

@israel-hdez israel-hdez moved this from To-do This Sprint to Groomed Issues in ODH Model Serving Planning Aug 2, 2023
@heyselbi heyselbi moved this to To-do/Groomed in ODH Model Serving Planning Aug 21, 2023
@heyselbi heyselbi closed this as completed Dec 5, 2023
@github-project-automation github-project-automation bot moved this from To-do/Groomed to Done in ODH Model Serving Planning Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature New feature odh-release/1.8 Need to do for ODH Release v1.8.0
Projects
Status: Done
Status: No status
Status: Done
Development

No branches or pull requests

6 participants