From c1cf3886d156176eb088a921d2a62e8723319a1d Mon Sep 17 00:00:00 2001 From: Jooho Lee Date: Thu, 23 Nov 2023 14:56:19 -0500 Subject: [PATCH] Support verify variable with storage-config json style (fix-3263) (#3267) support verify variable with storage-config json style (fix-3263) Signed-off-by: jooho --- python/kserve/kserve/storage/storage.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/kserve/kserve/storage/storage.py b/python/kserve/kserve/storage/storage.py index 906d17a04d..7dcd299c2a 100644 --- a/python/kserve/kserve/storage/storage.py +++ b/python/kserve/kserve/storage/storage.py @@ -117,6 +117,7 @@ def _update_with_storage_spec(): os.environ["AWS_SECRET_ACCESS_KEY"] = storage_secret_json.get("secret_access_key", "") os.environ["AWS_DEFAULT_REGION"] = storage_secret_json.get("region", "") os.environ["AWS_CA_BUNDLE"] = storage_secret_json.get("certificate", "") + os.environ["S3_VERIFY_SSL"] = storage_secret_json.get("verify_ssl", "1") os.environ["awsAnonymousCredential"] = storage_secret_json.get("anonymous", "") if storage_secret_json.get("type", "") == "hdfs" or storage_secret_json.get("type", "") == "webhdfs": @@ -168,7 +169,7 @@ def _download_s3(uri, temp_dir: str): kwargs.update({"endpoint_url": endpoint_url}) verify_ssl = os.getenv("S3_VERIFY_SSL") if verify_ssl: - verify_ssl = verify_ssl != "0" + verify_ssl = not verify_ssl.lower() in ["0", "false"] kwargs.update({"verify": verify_ssl}) s3 = boto3.resource("s3", **kwargs) parsed = urlparse(uri, scheme='s3')