Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSPv2] Add/manage missing empty tekton config CMs/Secrets #377

Closed
Tracked by #335
gmfrasca opened this issue Oct 5, 2023 · 4 comments
Closed
Tracked by #335

[DSPv2] Add/manage missing empty tekton config CMs/Secrets #377

gmfrasca opened this issue Oct 5, 2023 · 4 comments

Comments

@gmfrasca
Copy link
Member

gmfrasca commented Oct 5, 2023

In the DSPv2 PoC, there are some CMs and Secrets that need to simply be created in order for the v2 backend component to populate data with. To be specific, these are:

Config Maps

  • config-artifact-bucket
  • config-artifact-pvc
  • config-defaults
  • config-observability
  • config-spire
  • config-trusted-resources
  • feature-flags

Secrets

  • kfp-exithandler-webhook-certs
  • kfptask-webhook-certs
  • tekton-pipelineloop-webhook-certs

Add these to the V2 Manifests, or alternatively, figure out why the OpenShift Pipelines Operator (v1.12.0+) is no longer supply them.

@amadhusu
Copy link
Contributor

Testing @gmfrasca's branch of dspv2 with Openshift Pipelines Operator v1.11.1 to test if the creation of these Config Maps and Secrets works as its supposed to.

@amadhusu
Copy link
Contributor

amadhusu commented Oct 19, 2023

So this isn't related to Openshift Pipelines Operator not providing these respective Config Maps & Secrets as I can see in both Openshift Pipelines Operator v1.11.1 and v1.12.0, there is an instance "pipeline-main-static-x" of CRD TektonInstallerSets which successfully creates this in the openshift-pipelines namespace. Also only the webhook pods are failing to access/leverage these config maps and secrets.

Currently Investigating the code under v2 and checking if there is something related to how the respective roles are missing some get/list permissions for these respective failures.

@HumairAK HumairAK mentioned this issue Oct 27, 2023
8 tasks
@amadhusu
Copy link
Contributor

Pulled in all the latest commits on the dspv2 branch to catch up on backlog, the issue persists. So I am going ahead with manual creation of these secrets & configs and will update codebase if that works.

@amadhusu amadhusu linked a pull request Nov 6, 2023 that will close this issue
3 tasks
@amadhusu amadhusu removed a link to a pull request Nov 6, 2023
3 tasks
@rimolive
Copy link
Contributor

Looks like #443 is merged so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: No status
Development

No branches or pull requests

4 participants