From 32326be120e4ee320832101357338aab1aa78e23 Mon Sep 17 00:00:00 2001
From: Humair Khan <humair88@hotmail.com>
Date: Fri, 24 Mar 2023 14:16:26 -0400
Subject: [PATCH] Remove redundant/unused code.

Signed-off-by: Humair Khan <humair88@hotmail.com>
---
 controllers/dspipeline_controller.go | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/controllers/dspipeline_controller.go b/controllers/dspipeline_controller.go
index f37837c5c..d80a78f7f 100644
--- a/controllers/dspipeline_controller.go
+++ b/controllers/dspipeline_controller.go
@@ -62,10 +62,8 @@ func (r *DSPAReconciler) Apply(owner mf.Owner, params *DSPAParams, template stri
 		return err
 	}
 
-	if err = tmplManifest.Apply(); err != nil {
-		return err
-	}
-	return nil
+	err = tmplManifest.Apply()
+	return err
 }
 
 func (r *DSPAReconciler) ApplyWithoutOwner(params *DSPAParams, template string, fns ...mf.Transformer) error {
@@ -79,10 +77,8 @@ func (r *DSPAReconciler) ApplyWithoutOwner(params *DSPAParams, template string,
 		return err
 	}
 
-	if err = tmplManifest.Apply(); err != nil {
-		return err
-	}
-	return nil
+	err = tmplManifest.Apply()
+	return err
 }
 
 func (r *DSPAReconciler) DeleteResource(params *DSPAParams, template string, fns ...mf.Transformer) error {
@@ -96,10 +92,8 @@ func (r *DSPAReconciler) DeleteResource(params *DSPAParams, template string, fns
 		return err
 	}
 
-	if err = tmplManifest.Delete(); err != nil {
-		return err
-	}
-	return nil
+	err = tmplManifest.Delete()
+	return err
 }
 
 func (r *DSPAReconciler) DeleteResourceIfItExists(ctx context.Context, obj client.Object, nn types.NamespacedName) error {
@@ -179,7 +173,7 @@ func (r *DSPAReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 		if controllerutil.ContainsFinalizer(dspa, finalizerName) {
 			params.Name = dspa.Name
 			params.Namespace = dspa.Namespace
-			if err := r.cleanUpResources(ctx, req, dspa, params); err != nil {
+			if err := r.cleanUpResources(params); err != nil {
 				return ctrl.Result{}, err
 			}
 			controllerutil.RemoveFinalizer(dspa, finalizerName)
@@ -259,7 +253,7 @@ func (r *DSPAReconciler) SetupWithManager(mgr ctrl.Manager) error {
 }
 
 // Clean Up any resources not handled by garbage collection, like Cluster ResourceRequirements
-func (r *DSPAReconciler) cleanUpResources(ctx context.Context, req ctrl.Request, dsp *dspav1alpha1.DataSciencePipelinesApplication, params *DSPAParams) error {
+func (r *DSPAReconciler) cleanUpResources(params *DSPAParams) error {
 	err := r.CleanUpCommon(params)
 	if err != nil {
 		return err