Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for caikit, tgi and istio were not observed in the deployed namespace #72

Closed
manosnoam opened this issue Sep 4, 2023 · 1 comment · Fixed by #98
Closed

Metrics for caikit, tgi and istio were not observed in the deployed namespace #72

manosnoam opened this issue Sep 4, 2023 · 1 comment · Fixed by #98
Assignees

Comments

@manosnoam
Copy link

manosnoam commented Sep 4, 2023

After following instructions to deploy and access Metrics on RHODS 1.32 v2 RC7 (brew.registry.redhat.io/rh-osbs/iib:568805), according to:
https://github.com/opendatahub-io/caikit-tgis-serving/blob/main/demo/kserve/metrics.md
which involves applying 2 configmaps into a test namespace (for example TEST_NS=watsonx)

The configMaps were created in the test namespace:
image

$▶ oc describe configmap/cluster-monitoring-config -n ${TEST_NS}
Name:         cluster-monitoring-config
Namespace:    watsonx
Labels:       <none>
Annotations:  <none>

Data
====
config.yaml:
----
enableUserWorkload: true


BinaryData
====

Events:  <none>

$▶ oc describe configmap/user-workload-monitoring-config -n ${TEST_NS}
Name:         user-workload-monitoring-config
Namespace:    watsonx
Labels:       <none>
Annotations:  <none>

Data
====
config.yaml:
----
prometheus:
  logLevel: debug 
  retention: 15d #Change as needed


BinaryData
====

Events:  <none>

But the expected metrics for caikit, tgi or istio were not observed as expected:
image

Looking at the default namespace openshift-monitoring - we can see that the original configmap was not changed:

image

Apparently, if updating the default configmaps in openshift-user-workload-monitoring and in cluster-monitoring-config then the expected metrics show up.

Related feature: opendatahub-io/caikit#3

@israel-hdez israel-hdez moved this from New/Backlog to To-do/Groomed in ODH Model Serving Planning Sep 4, 2023
@manosnoam manosnoam changed the title Metrics for caikit, tgi and istio were not observed Metrics for caikit, tgi and istio were not observed in the deployed namespace Sep 5, 2023
@VedantMahabaleshwarkar
Copy link
Contributor

VedantMahabaleshwarkar commented Oct 5, 2023

@manosnoam Hey, i updated the instructions to remove the -n ${TEST_NS} from the oc apply commands for the UWM configmaps. This should result in them getting applied in the correct namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants