Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify I/O throttling differences between cgroup v1 and v2 #1194

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Apr 3, 2023

This PR adds a note to the OCI Runtime Specification documentation, clarifying the differences in I/O throttling behavior between cgroup v1 and cgroup v2. Specifically, it mentions that I/O throttling settings in cgroup v1 apply only to Direct I/O due to kernel implementation constraints, while this limitation does not exist in cgroup v2.

By providing this information, users will be better informed about these differences and can make more appropriate decisions when configuring.

Signed-off-by: utam0k <k0ma@utam0k.jp>
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Apr 3, 2023
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 5bc62f1 into opencontainers:main Apr 18, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request May 22, 2023
12 tasks
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants