Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop hooks (now that we have a create/start split) #473

Closed
wking opened this issue May 27, 2016 · 1 comment
Closed

Drop hooks (now that we have a create/start split) #473

wking opened this issue May 27, 2016 · 1 comment

Comments

@wking
Copy link
Contributor

wking commented May 27, 2016

With #384, I expect we will be dropping hooks on all platforms. The only uncertainty is around pre-pivot mount manipulation, and I'm not clear on why you need a hook for that. In the absence of a spec-defined run (added at one point during #384 development but removed before merge), I see no reason to keep hooks around.

Can anyone explain why we need hooks for pre-pivot mount manipulations? Or what other use-cases need hooks (vs. calling stuff between create and start)? Otherwise we should drop them to avoid
complications like #256 and #472.

@wking
Copy link
Contributor Author

wking commented Aug 18, 2016

We're keeping hooks. Reasoning here.

@wking wking closed this as completed Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant