Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc is not using opencontainers/runtime-spec config for seccomp format #1273

Closed
grantseltzer opened this issue Jan 13, 2017 · 4 comments
Closed

Comments

@grantseltzer
Copy link

The seccomp struct used in runc is redefined from runtime-spec's definition which is already vendored in. They're almost the same except for the Operator type being an int instead of a string. I'm fairly certain this is a relic from Docker.

If I can get some feedback, I can switch it over for consistencies sake without making any changes to the configs package api.

@grantseltzer
Copy link
Author

It's also worth noting that there's discussion to update runtime-spec's seccomp format to a more expressive version currently being used in cri-o. If that comes to fruition it'd make more sense to do this afterwards.

@justincormack
Copy link
Contributor

We could probably fix this anyway now.

@grantseltzer
Copy link
Author

@justincormack I have a fix ready locally, going to wait for more discussion on the runtime-spec PR before opening something here

@crosbymichael
Copy link
Member

This has been fixed when we bumped to runtime-spec rc5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants