Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization.md needs a big overhaul #36

Closed
vbatts opened this issue Apr 18, 2016 · 12 comments
Closed

Serialization.md needs a big overhaul #36

vbatts opened this issue Apr 18, 2016 · 12 comments

Comments

@vbatts
Copy link
Member

vbatts commented Apr 18, 2016

Per #26 (comment) and
https://github.com/opencontainers/image-spec/issues?q=is%3Aissue+is%3Aopen+label%3A%22component%2Fserialization+spec%22

There is much cruft carried forward with the version that was cherry-picked for this image-spec.

@vbatts
Copy link
Member Author

vbatts commented Apr 22, 2016

moby/moby#22264

@philips
Copy link
Contributor

philips commented Apr 27, 2016

@vbatts I am ready to merge this improved doc after reviewing it. Are we blocked on that PR or can we merge it as-is and then add fixes as they go?

@philips philips added this to the v0.1.0 milestone Apr 27, 2016
@vbatts
Copy link
Member Author

vbatts commented Apr 27, 2016

hmm. i'm okay with merging and adding fixes as we/they go

@philips
Copy link
Contributor

philips commented Apr 27, 2016

@vbatts you got dis or do you want me to do it? Lets wait a day or so to merge it.

@vbatts
Copy link
Member Author

vbatts commented Apr 27, 2016

k. I'll open a PR

@philips
Copy link
Contributor

philips commented Apr 28, 2016

@vbatts this stuff replaces the config in serialization.md?

@vbatts
Copy link
Member Author

vbatts commented Apr 28, 2016

not so much replaces, but updates

@philips
Copy link
Contributor

philips commented May 2, 2016

@vbatts are we waiting on anything or can this be closed out?

@philips philips modified the milestones: v0.2.0, v0.1.0 May 5, 2016
@philips
Copy link
Contributor

philips commented May 5, 2016

Moving to v0.2.0 as I don't know what we are blocked on or what updates we need. Help would be appreciated @vbatts.

@philips
Copy link
Contributor

philips commented May 24, 2016

@vbatts moby/moby#22264 has been merged. So this should be easy?!

@philips
Copy link
Contributor

philips commented May 26, 2016

The diff is very trivial from moby/moby#22264 to the OCI version and has no material changes. I am going to close this issue out and open a PR for the one wording improvement.

Word diff: https://gist.github.com/philips/684f2514b071fff1b6d4b68a36747432

@philips
Copy link
Contributor

philips commented May 26, 2016

Closing PR: #91

@philips philips closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants