Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backer snippet is not responsive #1399

Open
astorije opened this issue Nov 4, 2018 · 3 comments
Open

Backer snippet is not responsive #1399

astorije opened this issue Nov 4, 2018 · 3 comments

Comments

@astorije
Copy link

astorije commented Nov 4, 2018

Describe the bug

The snippet for backer avatars provided at https://opencollective.com/xyz/edit#export are not responsive and go out of the screen on mobile.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://deploy-preview-138--thelounge.netlify.com/community#donate-to-the-project on mobile or using the device emulation in browsers' dev tools.
  2. You will see that as opposed to other pages of this website, the snippet goes out of the container.

Expected behavior

When the snippet is bigger than the container, it should either resize, or avatars should jump to the next line.

Screenshots

Good (desktop) Bad (mobile)
screen shot 2018-11-04 at 00 44 28 screen shot 2018-11-04 at 00 45 03screen shot 2018-11-04 at 00 45 14
@znarf
Copy link
Member

znarf commented Nov 6, 2018

@astorije Your link to reproduce the issue doesn't work anymore, can you update it? Thank you!

@astorije
Copy link
Author

astorije commented Nov 8, 2018

Uh, that's odd, thanks for the nudge!
I have updated the PR description. This is the code that corresponds to this btw, if that's any useful.

Thanks!

@znarf
Copy link
Member

znarf commented Nov 8, 2018

@astorije Thank you for updating the PR. We will check what we can do.

In the meantime, I have a potential work around to propose, you can use the width parameter in the SVG URL. ie: https://opencollective.com/thelounge/backers.svg?avatarHeight=50&width=400.

@alanna alanna added the hackathon candidates for internal team hackathon label Sep 18, 2019
@znarf znarf removed Bug Fix Fridays hackathon candidates for internal team hackathon labels Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants