Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #122

Open
Clemo97 opened this issue Jul 9, 2024 · 6 comments · May be fixed by #124
Open

Add support for Python 3.12 #122

Clemo97 opened this issue Jul 9, 2024 · 6 comments · May be fixed by #124
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Clemo97
Copy link

Clemo97 commented Jul 9, 2024

Describe the bug

Open-Source-Quartz-Solar-Forecast is dependent on pv-site-prediction. Some dependencies within pv-site-prediction are out of date and not supported by Python 3.12.

To Reproduce

Steps to reproduce the behavior:

  1. Make sure you have Python 3.12 installed and clone Open-Source-Quartz-Solar-Forecast
  2. Run pip install quartz-solar-forecast

Screenshot from 2024-07-09 11-12-40

Screenshot from 2024-07-09 11-14-20

@Clemo97 Clemo97 added the bug Something isn't working label Jul 9, 2024
@Clemo97 Clemo97 closed this as completed Jul 9, 2024
@peterdudfield
Copy link
Contributor

@Clemo97 did this work?

@peterdudfield peterdudfield reopened this Jul 18, 2024
@peterdudfield
Copy link
Contributor

this is needed for openclimatefix/open-source-quartz-solar-forecast#93

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield added the good first issue Good for newcomers label Jul 18, 2024
@zakwatts
Copy link
Collaborator

pandas-stubs should now be able to be updated as well: pandas-dev/pandas-stubs#625

@Clemo97
Copy link
Author

Clemo97 commented Jul 18, 2024

@Clemo97 did this work?

It did but unfortunately my computer died before I could push my changes😭 😭, hence why I never made a PR. All that's required is running the "poetry update" commands check poetry docs for that which will fail on some dependencies which you then have to manually adjust their version to one that is compatible to Python 3.12.
Pandas-stubs is just the first dependency that's incompatible but there are more, I found like 3 others.

@zakwatts
Copy link
Collaborator

Ahhh I do hate it when that happens! Okay, I'll have a look into this again now. Thanks for the effort you have put in!

@Vishesh-Mistry Vishesh-Mistry linked a pull request Aug 10, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants