Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure window for "recent_power" feature in the experiment config #111

Open
zakwatts opened this issue Feb 14, 2024 · 2 comments
Open

Comments

@zakwatts
Copy link
Collaborator

zakwatts commented Feb 14, 2024

Currently the window size to generate the recent_power feature is hardcoded in the recent_history.py file. Currently this value is to 30 minutes: recent_power_minutes = 30 here:

Hence, if PV data has been used that has a 5 minutely frequency, the last 6 values would be used (assuming no PV lag) to generate this recent_power feature. This is generally okay but for cases where we want to maximise the models performance for shorter horizon duration forecasts, we loose information by averaging out the recent power over a larger time than the forecast horizon duration.
https://github.com/openclimatefix/pv-site-prediction/blob/main/psp/models/recent_history.py#L519

  1. A quick solution is to hardcode the value in recent history, but this will affect how other models run.
  2. A more robust solution is to make this parameter configurable in the experiment config, but by default is set to 30.
  3. Another solution could be to pass in more recent_power features into the model.
@zakwatts
Copy link
Collaborator Author

Making into a configurable feature.

@peterdudfield
Copy link
Contributor

Yea I think 2. is a good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants