Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action to automate redeployment of ECS container in staging #52

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

DriesVerachtert
Copy link
Contributor

No description provided.

@DriesVerachtert DriesVerachtert force-pushed the staging_auto_redeploy branch 2 times, most recently from 036fbcc to 19d9798 Compare February 19, 2025 15:04
@DriesVerachtert DriesVerachtert marked this pull request as ready for review February 20, 2025 15:25
@DriesVerachtert
Copy link
Contributor Author

@pgetta I'm not 100% sure it will work, but as far as I know, this might be the way to run that redeploy after a build of a container for staging. I guess we can only test this by merging it in staging.

I've tested the redeploy thing on its own, but didn't test that "on: workflow_run:" trigger part at all.

@bilalesi
Copy link
Collaborator

thanks dries, this is really helpful

LGTM, one suggestion i think it's better to tag the deployment id by the last commit hash

aws ecs tag-resource \
            --resource-arn ${{ vars.AWS_STAGING_ECS_SERVICE }} \
            --tags key=deployment_id,value=${{ github.sha }}

@pgetta pgetta merged commit 5d57d2d into develop Feb 24, 2025
4 of 5 checks passed
@pgetta pgetta deleted the staging_auto_redeploy branch February 24, 2025 15:23
@pgetta
Copy link
Collaborator

pgetta commented Feb 24, 2025

@DriesVerachtert
Copy link
Contributor Author

great! I'll try to add that suggestion of Bilal for the tagging in a separate PR.

pgetta added a commit that referenced this pull request Feb 26, 2025
* Add accounting for memodel creation (#79)

* Add integration for me-model creation and accounting

* Start adding session class

* Create a OneShot class to simplify accounging usage

* Fix types, other lint issues

* Remove basePath from accounting API calls

* Correctly provide jobId when cancelling a reservation

* Make accounting base URL available in the client

* Disable accounting integration in local dev

* Add authz to the make reservation endpoint

* Revert type fix for getOrgFromSelfUrl and getProjFromSelfUrl methods

* Do not await while sending usage to accounting service

* Remove unnecessary comments

* GitHub action to automate redeployment of ECS container in staging (#52)

* GitHub action to automate redeployment of ECS container in staging

* Wait for the service to become stable after forcing a new deployment

---------

Co-authored-by: Pavlo Getta <pavlo.getta@openbraininstitute.org>

* Address issues with accounting integration (#83)

* Resolve routing conflict for accounting service

* Add other fixes

* Minor notebook style changes and fixes. (#84)

Notebooks table style changes and fixes.

* Consolidate push and deploy actions for staging ci (#86)

* Consolidate image publishing and re-deploying in staging

* Only allow building production images from main branch

* Add list of commits to the tag message

* Disable staging deployment for the current branch

* Debug extracting git commits

* Remove tag messages for now

* Third round of fixes (#87)

- (43) Add a section with main collaborators
- (39) Menu mobile should take the full width and full height
- Remove all contributors header
- (7) Redesign price list for mobile.

* Make sure model .hasPart property is treated correctly (#88)

* Clean up unused and made for SFN content (#85)

* Clean up unused and made for SFN content

* Clean up unused and made for SFN content #2

* Return back id token permissions for staging GitHub Action (#89)

* Return back accidentally removed id token permissions for github action for staging

* Limit concurrency for the staging deployment GH action (#90)

* Show real balances from API (#91)

* Show real balances from API

* Make virtualLabId optional for virtualLabBalanceAtomFamily

* Fourth round of fixes (#92)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections

* Fourth round of fixes (#93)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections
- (51) on the desktop, we've lost the little (i) info button over the 'Partial build'.

---------

Co-authored-by: Dries Verachtert <dries.verachtert@dries.eu>
Co-authored-by: g-bar <gilarturo.barriosdelvillar@openbraininstitute.org>
Co-authored-by: Tolokoban <contact@tolokoban.org>
pgetta added a commit that referenced this pull request Mar 7, 2025
* Correct production image tag (#63)

* Update productin API domains (#67)

* add prod tag to mailchimp (#69)

* add depolyment envs to env files (#71)

* revert coming-soon page (#82)

* Prepare for release of the institutional website (#94)

* Add accounting for memodel creation (#79)

* Add integration for me-model creation and accounting

* Start adding session class

* Create a OneShot class to simplify accounging usage

* Fix types, other lint issues

* Remove basePath from accounting API calls

* Correctly provide jobId when cancelling a reservation

* Make accounting base URL available in the client

* Disable accounting integration in local dev

* Add authz to the make reservation endpoint

* Revert type fix for getOrgFromSelfUrl and getProjFromSelfUrl methods

* Do not await while sending usage to accounting service

* Remove unnecessary comments

* GitHub action to automate redeployment of ECS container in staging (#52)

* GitHub action to automate redeployment of ECS container in staging

* Wait for the service to become stable after forcing a new deployment

---------

Co-authored-by: Pavlo Getta <pavlo.getta@openbraininstitute.org>

* Address issues with accounting integration (#83)

* Resolve routing conflict for accounting service

* Add other fixes

* Minor notebook style changes and fixes. (#84)

Notebooks table style changes and fixes.

* Consolidate push and deploy actions for staging ci (#86)

* Consolidate image publishing and re-deploying in staging

* Only allow building production images from main branch

* Add list of commits to the tag message

* Disable staging deployment for the current branch

* Debug extracting git commits

* Remove tag messages for now

* Third round of fixes (#87)

- (43) Add a section with main collaborators
- (39) Menu mobile should take the full width and full height
- Remove all contributors header
- (7) Redesign price list for mobile.

* Make sure model .hasPart property is treated correctly (#88)

* Clean up unused and made for SFN content (#85)

* Clean up unused and made for SFN content

* Clean up unused and made for SFN content #2

* Return back id token permissions for staging GitHub Action (#89)

* Return back accidentally removed id token permissions for github action for staging

* Limit concurrency for the staging deployment GH action (#90)

* Show real balances from API (#91)

* Show real balances from API

* Make virtualLabId optional for virtualLabBalanceAtomFamily

* Fourth round of fixes (#92)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections

* Fourth round of fixes (#93)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections
- (51) on the desktop, we've lost the little (i) info button over the 'Partial build'.

---------

Co-authored-by: Dries Verachtert <dries.verachtert@dries.eu>
Co-authored-by: g-bar <gilarturo.barriosdelvillar@openbraininstitute.org>
Co-authored-by: Tolokoban <contact@tolokoban.org>

* Revert coming soon view in the root page (#95)

* Remove custom non-sanity privacy page (#96)

* Hotfix/add domain redirect (#104)

* Add tmp redirect to primary hostname (#99)

---------

Co-authored-by: Bilal MEDDAH <b_meddah@esi.dz>
Co-authored-by: Dries Verachtert <dries.verachtert@dries.eu>
Co-authored-by: g-bar <gilarturo.barriosdelvillar@openbraininstitute.org>
Co-authored-by: Tolokoban <contact@tolokoban.org>
pgetta added a commit that referenced this pull request Mar 7, 2025
* Add accounting for memodel creation (#79)

* Add integration for me-model creation and accounting

* Start adding session class

* Create a OneShot class to simplify accounging usage

* Fix types, other lint issues

* Remove basePath from accounting API calls

* Correctly provide jobId when cancelling a reservation

* Make accounting base URL available in the client

* Disable accounting integration in local dev

* Add authz to the make reservation endpoint

* Revert type fix for getOrgFromSelfUrl and getProjFromSelfUrl methods

* Do not await while sending usage to accounting service

* Remove unnecessary comments

* GitHub action to automate redeployment of ECS container in staging (#52)

* GitHub action to automate redeployment of ECS container in staging

* Wait for the service to become stable after forcing a new deployment

---------

Co-authored-by: Pavlo Getta <pavlo.getta@openbraininstitute.org>

* Address issues with accounting integration (#83)

* Resolve routing conflict for accounting service

* Add other fixes

* Minor notebook style changes and fixes. (#84)

Notebooks table style changes and fixes.

* Consolidate push and deploy actions for staging ci (#86)

* Consolidate image publishing and re-deploying in staging

* Only allow building production images from main branch

* Add list of commits to the tag message

* Disable staging deployment for the current branch

* Debug extracting git commits

* Remove tag messages for now

* Third round of fixes (#87)

- (43) Add a section with main collaborators
- (39) Menu mobile should take the full width and full height
- Remove all contributors header
- (7) Redesign price list for mobile.

* Make sure model .hasPart property is treated correctly (#88)

* Clean up unused and made for SFN content (#85)

* Clean up unused and made for SFN content

* Clean up unused and made for SFN content #2

* Return back id token permissions for staging GitHub Action (#89)

* Return back accidentally removed id token permissions for github action for staging

* Limit concurrency for the staging deployment GH action (#90)

* Show real balances from API (#91)

* Show real balances from API

* Make virtualLabId optional for virtualLabBalanceAtomFamily

* Fourth round of fixes (#92)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections

* Fourth round of fixes (#93)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections
- (51) on the desktop, we've lost the little (i) info button over the 'Partial build'.

* SEO (#97)

- (52) on the releasing soon page the Open Brain Institute logo changes color on hover to blue
- (53) Adding SEO.

* Bring back vlab deletion, add project deletion (#98)

* Bring back vlab deletion, add project deletion

* Disable cache for the virtual lab listing page

* Remove cache config

* Refresh list of vlab projects on deletion instead of purging the atom

* update eType values in filter, fix synapse config data (#100)

* Add tmp redirect to primary hostname (#99)

* Open notebook spec link in new tab (#101)

Open notebook spec link in new tab.

* Debug domain redirect and headers (#102)

* Disable logging headers for domain redirect (#103)

* Fine tuning (#105)

- (1) - [About] Center the portal column on large screen
 - (2) - [All paragraphs p ] Add a 42px margin bottom
 - (3) - [About] Increase the padding by 2.5em of the gray text in "our foundations"
 - (4) - [About] Collaborators grid columns: (1) Mobile: 1; (2): Tablet portrait: 3; (3) Desktop: 4; (4) Super-desktop: 5
 - (5) - [All pages] Add a 32px padding all hover the footer
 - (6) - [Mission] name of the lab (subcellular, cellular, etc): Gabarito, weight 400, size 20-22px, word-spacing: 0.02em
 - (7) - [Team] For member of the board and executive board have two lines (ellipsis) of biography and a button read more to expand
 - (8) - [Home] Add new blocks Milestones slider
 - (9) - [About] Profile card (Henry) should be left aligned.
 - (10) - [Resources] Add a gray border {#D9D9D9) to each resource
 - (11) - [Resources] Put a line height of 1.55 for the description
 - (12) - [Resources] Resources card should be left aligned in the grid

* Fix contact page (#106)

* add user journey store to indexdb (#107)

* Add a big button to go to the coming-soon pge from the pricing (#109)

* Go to your lab buttons (#110)

* Add a big button to go to the coming-soon pge from the pricing

* Linter fixed

* Linter fixed (#111)

* New style for the coming-soon button (#113)

* Resolve conflicts with main (#116)

* Correct production image tag (#63)

* Update productin API domains (#67)

* add prod tag to mailchimp (#69)

* add depolyment envs to env files (#71)

* revert coming-soon page (#82)

* Prepare for release of the institutional website (#94)

* Add accounting for memodel creation (#79)

* Add integration for me-model creation and accounting

* Start adding session class

* Create a OneShot class to simplify accounging usage

* Fix types, other lint issues

* Remove basePath from accounting API calls

* Correctly provide jobId when cancelling a reservation

* Make accounting base URL available in the client

* Disable accounting integration in local dev

* Add authz to the make reservation endpoint

* Revert type fix for getOrgFromSelfUrl and getProjFromSelfUrl methods

* Do not await while sending usage to accounting service

* Remove unnecessary comments

* GitHub action to automate redeployment of ECS container in staging (#52)

* GitHub action to automate redeployment of ECS container in staging

* Wait for the service to become stable after forcing a new deployment

---------

Co-authored-by: Pavlo Getta <pavlo.getta@openbraininstitute.org>

* Address issues with accounting integration (#83)

* Resolve routing conflict for accounting service

* Add other fixes

* Minor notebook style changes and fixes. (#84)

Notebooks table style changes and fixes.

* Consolidate push and deploy actions for staging ci (#86)

* Consolidate image publishing and re-deploying in staging

* Only allow building production images from main branch

* Add list of commits to the tag message

* Disable staging deployment for the current branch

* Debug extracting git commits

* Remove tag messages for now

* Third round of fixes (#87)

- (43) Add a section with main collaborators
- (39) Menu mobile should take the full width and full height
- Remove all contributors header
- (7) Redesign price list for mobile.

* Make sure model .hasPart property is treated correctly (#88)

* Clean up unused and made for SFN content (#85)

* Clean up unused and made for SFN content

* Clean up unused and made for SFN content #2

* Return back id token permissions for staging GitHub Action (#89)

* Return back accidentally removed id token permissions for github action for staging

* Limit concurrency for the staging deployment GH action (#90)

* Show real balances from API (#91)

* Show real balances from API

* Make virtualLabId optional for virtualLabBalanceAtomFamily

* Fourth round of fixes (#92)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections

* Fourth round of fixes (#93)

- (13) subcellular / cellular / circuit / .. grid : is not obvious we have other scale on mobile
- (6) The news list is too long. Add a More button
- (50) Currency combo goes behind the plans header.
- Bottom margin of 42 in paragraphs sections
- (51) on the desktop, we've lost the little (i) info button over the 'Partial build'.

---------

Co-authored-by: Dries Verachtert <dries.verachtert@dries.eu>
Co-authored-by: g-bar <gilarturo.barriosdelvillar@openbraininstitute.org>
Co-authored-by: Tolokoban <contact@tolokoban.org>

* Revert coming soon view in the root page (#95)

* Remove custom non-sanity privacy page (#96)

* Hotfix/add domain redirect (#104)

* Add tmp redirect to primary hostname (#99)

---------

Co-authored-by: Bilal MEDDAH <b_meddah@esi.dz>
Co-authored-by: Dries Verachtert <dries.verachtert@dries.eu>
Co-authored-by: g-bar <gilarturo.barriosdelvillar@openbraininstitute.org>
Co-authored-by: Tolokoban <contact@tolokoban.org>

---------

Co-authored-by: Dries Verachtert <dries.verachtert@dries.eu>
Co-authored-by: g-bar <gilarturo.barriosdelvillar@openbraininstitute.org>
Co-authored-by: Tolokoban <contact@tolokoban.org>
Co-authored-by: Bilal MEDDAH <b_meddah@esi.dz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants