Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all /dev/mem access #20

Closed
shenki opened this issue Dec 3, 2015 · 2 comments
Closed

Remove all /dev/mem access #20

shenki opened this issue Dec 3, 2015 · 2 comments

Comments

@shenki
Copy link
Member

shenki commented Dec 3, 2015

Currently we poke at /dev/mem for making sure a bunch of things are configured in the way they need to be. This is bad, as userspace and the kernel can step on each others toes, and create bugs that are hard to debug.

Ultimately there will be proper kernel features in the form of device tree descriptions and a pinmux driver. For now, lets stick them in arch/arm/mach-aspeed/aspeed.c.

We could disable /dev/mem entirely, but it is useful for debugging and testing, so instead we will make it a rule that no checked in code touches it and keep it around for convenience.

@shenki
Copy link
Member Author

shenki commented Dec 3, 2015

@nkskjames will have a crack at this.

We can use the device tree to make this machine dependant. Something like shenki/linux@98c91d9

@nkskjames
Copy link
Contributor

Fixed with openbmc/linux@6da1b0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants