Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division undefined error in Coverage #3

Open
renep opened this issue Apr 13, 2017 · 13 comments
Open

Division undefined error in Coverage #3

renep opened this issue Apr 13, 2017 · 13 comments

Comments

@renep
Copy link
Contributor

renep commented Apr 13, 2017

@davetrux wrote:
Since upgrading to Xcode 8.3.1 the coverage task fails with a Division undefined error:

Caused by: java.lang.ArithmeticException: Division undefined
        at org.openbakery.coverage.model.SourceFile.getCoverage(SourceFile.groovy:138)
        at org.openbakery.coverage.model.SourceFile$getCoverage$2.call(Unknown Source)
        at org.openbakery.coverage.report.ReportData.getData(ReportData.groovy:91)
        at org.openbakery.coverage.report.XMLReport.generate(XMLReport.groovy:27)
        at org.openbakery.coverage.report.XMLReport$generate.call(Unknown Source)
        at org.openbakery.coverage.Report.createReport(Report.groovy:149)
        at org.openbakery.coverage.Report.create(Report.groovy:111)
        at org.openbakery.coverage.Report$create$1.callCurrent(Unknown Source)
        at org.openbakery.coverage.Report.create(Report.groovy:76)
        at org.openbakery.coverage.Report$create$0.call(Unknown Source)
        at org.openbakery.coverage.CoverageTask.coverage(CoverageTask.groovy:46)
        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)
        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
        at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)
        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)
        at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)
        ... 70 more

It seems like the lines covered and lines executed are no longer being generated or pulled from the coverage report?

All of our projects are experiencing this.

See: openbakery/gradle-xcodePlugin#349

@renep
Copy link
Contributor Author

renep commented Apr 13, 2017

Looks like the coverage format has changed

@pnwaterloo
Copy link

@renep Just wondering if you have any updates? Xcode v 8.3.2 & 8.3.3 are both giving "division undefined" error.
Execution failed for task ':coverage'

Disivion Undefined

@renep
Copy link
Contributor Author

renep commented Aug 7, 2017

Nope. Have not found any time to fix this.

@eugenious
Copy link
Contributor

I'm encountering this problem too. Maybe I could work on it and submit a PR?

@renep
Copy link
Contributor Author

renep commented Aug 9, 2017

PR are always welcome, especially if they also contain unit tests 😀

@emileng
Copy link

emileng commented Aug 10, 2017

Running into the same error. Appreciate a fix to the code.

@eugenious
Copy link
Contributor

okay, PR submitted, please take a look and let me know what you think

@eugenious
Copy link
Contributor

how soon can you release the next version that contains this fix?

@renep
Copy link
Contributor Author

renep commented Aug 14, 2017

I have already created version 0.9.4 today

@eugenious
Copy link
Contributor

Don't you need to release 0.9.4 of this project, and then add it to the gradle-xcodePlugin project and release that project? I don't mean to appear pushy, just wondering if there's more that I can do or if it's up to you to release new versions of both projects?

@renep
Copy link
Contributor Author

renep commented Aug 17, 2017

Latest develop version of the gradle-xcodePlugin (0.15.1.develop.115) includes 0.9.4. This version was created on the 14th Aug. (Every commit on the develop branch triggers a new develop build)
See also https://github.com/openbakery/gradle-xcodePlugin/tree/develop#current-develop-version

@eugenious
Copy link
Contributor

Oh great! I didn't realize that.

Thanks.

@eugenious
Copy link
Contributor

I confirm that it's working as expected.
Will you release a new version of the gradle-xcodePlugin soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants