-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-no media types in paths #31
Merged
philsturgeon
merged 12 commits into
apisyouwonthate:main
from
savage-alex:feat-no-media-types-in-paths
Sep 23, 2022
Merged
feat-no media types in paths #31
philsturgeon
merged 12 commits into
apisyouwonthate:main
from
savage-alex:feat-no-media-types-in-paths
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
approved these changes
Sep 8, 2022
philsturgeon
reviewed
Sep 8, 2022
15219d5
to
9bfc392
Compare
@philsturgeon Sadly unable to merge this as the Tests are stuck. |
9bfc392
to
6a0c312
Compare
@savage-alex tests are no longer stuck. |
reduce code duplication on regex Co-authored-by: Phil Sturgeon <67381+philsturgeon@users.noreply.github.com>
…age-alex/style-guide into feat-no-media-types-in-paths
Added tests for OAS2 api definitions and removed old test
@philsturgeon OAS2 tested fine and tests added. |
philsturgeon
approved these changes
Sep 23, 2022
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rule to address issue #24
Tests added
Tested with spectral CLI v6.5.0 and VS code extention v1.0