Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add Bitmap caching support #24

Closed
openaphid opened this issue Dec 12, 2012 · 3 comments
Closed

Add Bitmap caching support #24

openaphid opened this issue Dec 12, 2012 · 3 comments
Assignees
Milestone

Comments

@openaphid
Copy link
Owner

Bitmap instances are constantly created and recycled during flipping.

Implementing a bitmap cache could improve performance and reduce the risk of OOM errors.

@ghost ghost assigned openaphid Dec 14, 2012
@VAdaihiep
Copy link

I think if the screenshot already recycle before created new screenshot, the memory can not be out when flip many time because it's de-allocate after recycle(). I mean maybe created and recycle bitmap is not the reason of OOM error, maybe the reason is: Somethings goes bigger after each flipping -> OOM errors.

@openaphid
Copy link
Owner Author

The issue is about to reduce the risk, not to avoid it.

I analyzed the heap status after flipping 100+ pages. There is no bitmap instances or other objects leaking. Then I thought OOM is caused by the behavior of adapter.

Please refer to #33, I will push a fix in a minute

@openaphid
Copy link
Owner Author

Leave it close as the memory leak has been identified in #33

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants