fix(cli/audio): file format detection failing for whisper #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiswillbeyourgithub
changed the title
thiswillbeyourgithub
force-pushed
the
main
branch
2 times, most recently
from
a875a14 to
798960a
Compare
thiswillbeyourgithub
force-pushed
the
main
branch
from
798960a to
13080a6
Compare
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
thiswillbeyourgithub
force-pushed
the
main
branch
from
1b8263e to
83a4cda
Compare
RobertCraigie
changed the title
Merged
|
Thanks for the PR! |
stainless-bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
megamanics
pushed a commit
to devops-testbed/openai-python
that referenced
this pull request
Aug 14, 2024
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
Signed-off-by: thiswillbeyourgithub <26625900+thiswillbeyourgithub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #333
My initial problem
My case is using
openai api audio.transcriptions.create -f audio.mp3. Without the fix the returned value isError: Error code: 400 - {'error': {'message': "Unrecognized file format. Supported formats: ['flac', 'm4a', 'mp3', 'mp4', 'mpeg', 'mpga', 'oga', 'ogg', 'wav', 'webm']", 'type': 'invalid_request_error', 'param': None, 'code': None}}.What the cause was
The issue was that using BufferReader to read from the audio file was not keeping the
nameattribute so the file detection code on the server side was failing.Quality
My fix is a viable workaround but a more invasive fix would be better. I found numerous other posts with this kind of issue for a while :
so I think this quick non invasive fix would be a good idea.
Edit: confirmed this fix is still relevant for 1.2.0. I'm on linux using python 3.9.0 for this test.