Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from pkg_resources import packaging seems not work with setuptools>=70.0.0 #446

Open
PawelPeczek-Roboflow opened this issue May 22, 2024 · 1 comment · May be fixed by rom1504/CLIP#10
Open

Comments

@PawelPeczek-Roboflow
Copy link

There was a release of setuptools 70.0.0 (https://pypi.org/project/setuptools/#history) which mentions changes in pkg_resources: https://setuptools.pypa.io/en/stable/history.html#v70-0-0, that gets deprecated: https://setuptools.pypa.io/en/stable/pkg_resources.html.

That implies need for change of entries like that in clip.py module

if packaging.version.parse(torch.__version__) < packaging.version.parse("1.7.1"):
    warnings.warn("PyTorch version 1.7.1 or higher is recommended")

into something supported.

@JamieMartin
Copy link
Contributor

JamieMartin commented Jun 3, 2024

I've opened a PR to fix this. Now works on my end.
#449
OR
#450
Depending on whether backward compatibility is desired.
Feel free to merge this if you need to get it working in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants