Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting code might fail with embed_options_disable_rfc #2004

Closed
koelibri opened this issue Nov 9, 2023 · 2 comments
Closed

Submitting code might fail with embed_options_disable_rfc #2004

koelibri opened this issue Nov 9, 2023 · 2 comments
Labels

Comments

@koelibri
Copy link

koelibri commented Nov 9, 2023

When using CodeOcean (from Moodle) via LTI and setting embed_options_disable_rfc=true the score delivery fails due to a Javascript error occurring right after clicking the submit button. [1]

Allowing or disabling requests for comments should not interfere with submitting scores to the calling LMS (such as Moodle). Imagine the use case of an examination situation: One would not allow to request comments, while, for obvious reasons, the submission of the gained scores are mandatory.

LTI session seem to differentiate between "with outcome" and "without outcome". If this determines the score submission back to the calling LMS, then the submit button should be shown with respect to that session type. If shown, the submit button then should work properly though.

[1]: Bildschirmfoto 2023-11-09 um 09 09 12

@MrSerth
Copy link
Member

MrSerth commented Nov 9, 2023

Many thanks for reporting your issue, @koelibri. I've aimed to reproduce the issue, but, based on the information given, wasn't able to do so. The following shows what I did and, according to my impression, everything worked well:

Reproduction.mov

Further, I did not saw any JavaScript error, besides using the same browser (Safari). Therefore, I would kindly ask you to provide more information on your bug:

  • Which CodeOcean version are you using?
  • Which browser version are you using?
  • What's the stack trace of the error?
  • Which steps have you taken before?
  • Did you try other combination of settings, i.e., with another exercise or execution environment?
  • Can you provide detailed reproduction steps, for example as a regression spec?

Moreover, please note our documentation on supported versions. As far as I can tell, the version you were using is not recent and thus not officially supported.

Finally, I am happy to share that the dedicated submit button will soon vanish with our work on #1698. Therefore, the situation might change further.

@MrSerth MrSerth changed the title LTI: possible side effect of embed_options_disable_rfc Submitting code might fail with embed_options_disable_rfc Nov 9, 2023
@koelibri
Copy link
Author

Having updated our CO instance the problem seems to be gone.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants