From e222634b1b47528a3ce692440b07cf981ab1b0a4 Mon Sep 17 00:00:00 2001 From: Steven Bal Date: Tue, 10 Dec 2024 14:23:27 +0100 Subject: [PATCH] :truck: [#200] Move setup_config files to setup_configuration directory --- src/nrc/conf/includes/base.py | 4 ++-- src/nrc/{config => setup_configuration}/__init__.py | 0 src/nrc/{config => setup_configuration}/authorization.py | 0 src/nrc/{config => setup_configuration}/models.py | 0 src/nrc/{config => setup_configuration}/site.py | 0 src/nrc/tests/commands/test_setup_configuration.py | 7 +------ src/nrc/tests/config/test_authorization_configuration.py | 2 +- src/nrc/tests/config/test_site_configuration.py | 2 +- 8 files changed, 5 insertions(+), 10 deletions(-) rename src/nrc/{config => setup_configuration}/__init__.py (100%) rename src/nrc/{config => setup_configuration}/authorization.py (100%) rename src/nrc/{config => setup_configuration}/models.py (100%) rename src/nrc/{config => setup_configuration}/site.py (100%) diff --git a/src/nrc/conf/includes/base.py b/src/nrc/conf/includes/base.py index 5316d161..cd5598c5 100644 --- a/src/nrc/conf/includes/base.py +++ b/src/nrc/conf/includes/base.py @@ -20,7 +20,7 @@ # Project applications. "nrc.accounts", "nrc.api", - "nrc.config", + "nrc.setup_configuration", "nrc.datamodel", "nrc.utils", ] @@ -134,7 +134,7 @@ SETUP_CONFIGURATION_STEPS = [ "zgw_consumers.contrib.setup_configuration.steps.ServiceConfigurationStep", "vng_api_common.contrib.setup_configuration.steps.JWTSecretsConfigurationStep", - "nrc.config.authorization.AuthorizationStep", + "nrc.setup_configuration.authorization.AuthorizationStep", # TODO these need to be implemented later # "notifications_api_common.contrib.setup_configuration.steps.NotificationConfigurationStep", # TODO this should be moved to `django-setup-configuration` diff --git a/src/nrc/config/__init__.py b/src/nrc/setup_configuration/__init__.py similarity index 100% rename from src/nrc/config/__init__.py rename to src/nrc/setup_configuration/__init__.py diff --git a/src/nrc/config/authorization.py b/src/nrc/setup_configuration/authorization.py similarity index 100% rename from src/nrc/config/authorization.py rename to src/nrc/setup_configuration/authorization.py diff --git a/src/nrc/config/models.py b/src/nrc/setup_configuration/models.py similarity index 100% rename from src/nrc/config/models.py rename to src/nrc/setup_configuration/models.py diff --git a/src/nrc/config/site.py b/src/nrc/setup_configuration/site.py similarity index 100% rename from src/nrc/config/site.py rename to src/nrc/setup_configuration/site.py diff --git a/src/nrc/tests/commands/test_setup_configuration.py b/src/nrc/tests/commands/test_setup_configuration.py index 7c3f229c..532d17bd 100644 --- a/src/nrc/tests/commands/test_setup_configuration.py +++ b/src/nrc/tests/commands/test_setup_configuration.py @@ -9,18 +9,13 @@ import requests_mock from jwt import decode -from notifications_api_common.contrib.setup_configuration.steps import ( - NotificationConfigurationStep, -) -from notifications_api_common.models import NotificationsConfig from rest_framework import status from vng_api_common.authorizations.models import AuthorizationsConfig from vng_api_common.authorizations.utils import generate_jwt from vng_api_common.contrib.setup_configuration.steps import JWTSecretsConfigurationStep from zgw_consumers.contrib.setup_configuration.steps import ServiceConfigurationStep -from nrc.config.authorization import AuthorizationStep -from nrc.config.site import SiteConfigurationStep +from nrc.setup_configuration.authorization import AuthorizationStep CONFIG_FILE_PATH = Path("src/nrc/tests/commands/files/setup_config_full.yaml").resolve() diff --git a/src/nrc/tests/config/test_authorization_configuration.py b/src/nrc/tests/config/test_authorization_configuration.py index 9bcbd146..dd04f2d7 100644 --- a/src/nrc/tests/config/test_authorization_configuration.py +++ b/src/nrc/tests/config/test_authorization_configuration.py @@ -4,7 +4,7 @@ from vng_api_common.authorizations.models import AuthorizationsConfig, ComponentTypes from zgw_consumers.test.factories import ServiceFactory -from nrc.config.authorization import AuthorizationStep +from nrc.setup_configuration.authorization import AuthorizationStep CONFIG_FILE_PATH = "src/nrc/tests/config/files/setup_config_auth_config.yaml" diff --git a/src/nrc/tests/config/test_site_configuration.py b/src/nrc/tests/config/test_site_configuration.py index f4e32aa5..29e73489 100644 --- a/src/nrc/tests/config/test_site_configuration.py +++ b/src/nrc/tests/config/test_site_configuration.py @@ -3,7 +3,7 @@ from django_setup_configuration.test_utils import execute_single_step -from nrc.config.site import SiteConfigurationStep +from nrc.setup_configuration.site import SiteConfigurationStep CONFIG_FILE_PATH = "src/nrc/tests/config/files/setup_config_sites.yaml"