Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the publish extensions github action failing? #273

Open
joaosa opened this issue Jan 24, 2021 · 4 comments
Open

Why is the publish extensions github action failing? #273

joaosa opened this issue Jan 24, 2021 · 4 comments
Labels
question Further information is requested

Comments

@joaosa
Copy link
Contributor

joaosa commented Jan 24, 2021

It seems like it has been failing for a while now, as it can be verified here 😄

There are a number of errors and they seem to be related to the following extensions:

> tsc -p ./

Error: src/preview/client.ts(101,30): error TS2339: Property 'swagger' does not exist on type 'string | object'.
  Property 'swagger' does not exist on type 'string'.
Error: src/preview/client.ts(104,28): error TS2339: Property 'openapi' does not exist on type 'string | object'.
  Property 'openapi' does not exist on type 'string'.
Error: src/preview/client.ts(105,28): error TS2339: Property 'openapi' does not exist on type 'string | object'.
  Property 'openapi' does not exist on type 'string'.
> tsc -p ./

Error: src/extension.ts(139,10): error TS2322: Type 'readonly WorkspaceFolder[] | undefined' is not assignable to type 'WorkspaceFolder[] | undefined'.
$ tsc -p ./
Error: node_modules/@types/node/index.d.ts(20,1): error TS1084: Invalid 'reference' directive syntax.

Is there anything I can do to help address this? I would probably start with checking the "faulty" extensions and seeing if I can reproduce the errors above.

@spoenemann
Copy link
Collaborator

The GH action fails if publishing any extension fails, so to address this we'd need to fix all extensions 😁. But the workflow still processes all extensions, so one failing extension should not affect the other extensions.

Sure, it would help a lot if you can contribute fixes to properly publish some more extensions. There are already lots of open issues about individual extensions failing to publish.

@joaosa
Copy link
Contributor Author

joaosa commented Jan 26, 2021

Thanks for clarifying 😄 . I'll see what I can do regarding this!

As for the fix you applied yesterday, it seems the extensions still didn't get published 😅

@spoenemann
Copy link
Collaborator

Right, the publishing CLI detected an extension with missing license and asked for user input, but no input is available in CI 😅 (see the end of the console log).

I created eclipse/openvsx#240 to improve this and removed that extension from the list.

@GitMensch
Copy link
Contributor

Even when the main issues here are now solved (like skipping the CI asking for a license) this seems like a general useful hint.
Maybe pin that, possibly renamed to "Why is the publish extensions github action failing"?

@spoenemann spoenemann added the question Further information is requested label Feb 19, 2021
@spoenemann spoenemann changed the title The publish extensions github action is failing Why is the publish extensions github action failing? Feb 19, 2021
@spoenemann spoenemann pinned this issue Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants