Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make table-generation is broken on Windows (Git Bash) after the switch over to weaver #994

Closed
trask opened this issue May 1, 2024 · 4 comments Β· Fixed by #1001
Closed

make table-generation is broken on Windows (Git Bash) after the switch over to weaver #994

trask opened this issue May 1, 2024 · 4 comments Β· Fixed by #1001
Assignees
Labels
area:other bug Something isn't working

Comments

@trask
Copy link
Member

trask commented May 1, 2024

Area(s)

area:other

What happened?

Description

Steps to Reproduce (if any)

Run make table-generation on Windows using Git Bash

Expected Result

Success πŸ˜„

Actual Result

βœ– IO error for operation on C:/Program Files/Git/source: No such file or directory (os error 2)
make: *** [Makefile:98: table-generation] Error 1

Semantic convention version

main

Additional context

No response

@trask trask added bug Something isn't working triage:needs-triage labels May 1, 2024
@trask trask changed the title make table-generation is broken on Windows (Git Bash) after switching over to weaver make table-generation is broken on Windows (Git Bash) after the switch over to weaver May 1, 2024
@joaopgrassi
Copy link
Member

Hum it used to work before? I guess it's something related to how Git Bash interprets the paths, maybe it messes it up between Unix/Windows πŸ€”

@joaopgrassi
Copy link
Member

joaopgrassi commented May 3, 2024

I set this var in the command MSYS_NO_PATHCONV=1 as per this old discussion docker-archive/toolbox#673 and it worked. Also seems to not change anything for those running on Linux/MacOS. I can send a PR

Edit: Weird, the other command attribute-registry-generation works normally πŸ€”

@jsuereth
Copy link
Contributor

jsuereth commented May 4, 2024

I'm investigating. This wasn't broken for me.

@jsuereth
Copy link
Contributor

jsuereth commented May 4, 2024

So - I think we need more information about your setup. I've been using WSL.

A few things to confirm:

  1. Can you run docker pull otel/weaver:latest? Unfortunately, we're using the latest tag right now, but this is fixable.
  2. Are you running make from the root of the semconv folder? It appears that windows is trying to read C:/Program Files/Git/source. However, for the docker image, we're trying to mount {semconv_root}/model as /source. I think @joaopgrassi may be right that there's some kind of directory conversion happening in your environment that's unwanted for the "docker" side of the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:other bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants