Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should db.sql.table include db.name? #718

Closed
trask opened this issue Feb 8, 2024 · 3 comments
Closed

Should db.sql.table include db.name? #718

trask opened this issue Feb 8, 2024 · 3 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Feb 8, 2024

Currently db.sql.table is defined as:

The name of the primary table that the operation is acting upon, including the database name (if applicable). [1]

I'm not sure why it includes db.name since we have a separate attribute specifically for that, and could parse the db.name out from the full db.sql.table expression.

@jcocchi
Copy link
Contributor

jcocchi commented Feb 9, 2024

I agree it doesn't make sense to duplicate the database name in both the db.name and db.sql.table attributes.

Many databases will have their own term for "table", in Cosmos DB it's called "container". Does it make sense to use a general term in the semantic convention or let each database have their own native terminology? (EDIT: didn't realize this was already tracked by #521 )

@Oberon00
Copy link
Member

Oberon00 commented Feb 9, 2024

This was changed in https://github.com/open-telemetry/opentelemetry-specification/pull/1973/files#diff-38d5c918b32cb78e2489cc98d2157cbe5c3306fcbfe4aa6235d25f3468305eeaR373

It used to say schema name, which imo makes sense for SQL as it would then be equivalent to saying that we want to have the fully qualified table name. But maybe we should just say that, i.e. instead of schema/db name, it should be the fully qualified table name?

@trask
Copy link
Member Author

trask commented Apr 24, 2024

Resolved by #870 where db.sql.table was replaced by db.collection.name, which

SHOULD match the value provided in the query and may be qualified with the schema and database name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants