-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should db.sql.table
include db.name
?
#718
Comments
I agree it doesn't make sense to duplicate the database name in both the Many databases will have their own term for "table", in Cosmos DB it's called "container". Does it make sense to use a general term in the semantic convention or let each database have their own native terminology? (EDIT: didn't realize this was already tracked by #521 ) |
This was changed in https://github.com/open-telemetry/opentelemetry-specification/pull/1973/files#diff-38d5c918b32cb78e2489cc98d2157cbe5c3306fcbfe4aa6235d25f3468305eeaR373 It used to say schema name, which imo makes sense for SQL as it would then be equivalent to saying that we want to have the fully qualified table name. But maybe we should just say that, i.e. instead of schema/db name, it should be the fully qualified table name? |
Resolved by #870 where
|
Currently
db.sql.table
is defined as:I'm not sure why it includes
db.name
since we have a separate attribute specifically for that, and could parse thedb.name
out from the fulldb.sql.table
expression.The text was updated successfully, but these errors were encountered: