-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CosmosDb Otel Specification #715
Comments
I think you could open up your proposal PR right away and the community will move on from there. I don't think there will be any "approval" in an issue. Most discussions happen on PRs directly, so feel free to do so! |
@joaopgrassi I think our on-paper contribution worklow was changed but the actual workflow never followed.
I think this is simply does not match reality. CC @open-telemetry/technical-committee |
Thanks for pointing out! I missed this somehow. But agree, from the issues/PRs I look I didn't see this workflow in place. |
thanks for the reply @joaopgrassi and @Oberon00 I tried to follow this only. As you said, I am going to create a PR with the proposal. |
@sourabh1007 was this issue resolved by open-telemetry/opentelemetry-specification#3097? thx |
There are 2 sections above. Operation level and Network level activities. |
My understanding that Also, small comment on:
any reason not to use It's also a good question what we want to stabilize for databases. |
@lmolkova |
@jcocchi should this issue be tracked as part of database semconv stabilization effort, or can it be addressed post-stability? Thanks |
@trask this can be tracked post-stability. We decided not to expose |
Context
CosmosDB SDK has 2 modes, Gateway (HTTP) and Direct (RNTBD), In different modes, for one operation call there can be multiple networks calls behind the scenes as failover/retries/replica selection, such logic runs in SDK itself.
Cosmos DB SDK is going to generate Activity at Operation level and Network level carrying some attributes with information.
Proposed Semantic conventions for SDK operation level calls
Azure/azure-cosmos-dotnet-v3#3058
Proposed Semantic conventions for SDK network (RNTBD) calls to CosmosDb
Status
Work is in progress to instrument .Net CosmosDb SDK with open telemetry support.
What I need
I need approval from open telemetry community to include cosmosdb specification in official opentelemetry specifications. As soon as I got approval here, I will get a PR out with the specifications.
Note: I am new in this community please let me know if I need to schedule a call or something in order to discuss this.
The text was updated successfully, but these errors were encountered: