-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process.cpu.count
metric to semantic conventions for OS process metrics.
#651
Comments
I think this is a really interesting point. It seems like Maybe it's good to remove |
@alanwest made similar open-telemetry/opentelemetry-specification#2439 (comment):
|
Agree. It would be instead useful if |
At a minimum, the spec needs to clarify that it is not possible for instrumentation written using OTel's language APIs to generate the Regarding removing it altogether, I'm not sure.. The collector's hostmetrics receiver generates the It is my understanding that the semantic conventions of the spec are not limited to only describing metrics produced using language APIs. If the collector produces this metric, and its semantics match what is here in the spec, then shouldn't we leave it in the spec?
I agree. This sounds like the semantics of the
Unless there is good reason not to, I would prefer to redefine the Regarding |
From the spec triage meeting: This looks like a reasonable request but the right approach still needs to be decided on, which is already being discussed in this thread. cc @open-telemetry/instr-wg for your input on this |
Hi @open-telemetry/instr-wg, may I kindly have your take on this? Thank you. |
This should be transferred to https://github.com/open-telemetry/semantic-conventions |
@open-telemetry/semconv-system-approvers can please take a look at this and see if needs more info or can be added to the system semconv project? thanks! |
What are you trying to achieve?
Add a metric to expose number of available processors to the current process to
semantic conventions for OS process metrics.
Proposed instrument name, type, unit and description:
process.cpu.count
Currently, the definition of
process.cpu.utilization
is "Difference in process.cpu.time since the last measurement, divided by the elapsed time and number of CPUs available to the process", which requires maintaining the state (in this case, the last collection time) of the instrument.The challenge encountered during implementation in .NET is:
open-telemetry/opentelemetry-dotnet-contrib#831
Potential workarounds:
open-telemetry/opentelemetry-dotnet-contrib#948
What did you expect to see?
Add
process.cpu.count
metric to the semantic conventions and let the backend do the computation.Given instrument values of
process.cpu.time
andprocess.cpu.count
, the backend will have sufficient data to calculate the CPU utilization metric.open-telemetry/opentelemetry-dotnet-contrib#981
Additional context.
Previous discussion related to this topic:
open-telemetry/opentelemetry-specification#2392
The text was updated successfully, but these errors were encountered: