-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is possible to align process.cpu.time,utilization
metrics defintion to system.cpu.time,utilization
#563
Comments
@open-telemetry/semconv-system-approvers could you check if this request makes sense? |
Can we transfer this to semantic-conventions @arminru? @david-luna I think the prefix part is being covered in /pull/330. I am not sure what the benefit of removing the constraint is, could you elaborate? |
Hi @mx-psi
the goal is alignment so I do not have strong opinion on removing it. maybe adding the constraint to system metrics? from a data consumer perspective I guess I'd expect to treat |
@open-telemetry/technical-committee can you transfer this issue? thx |
transferred |
While looking for references I came across this issue about cardinality open-telemetry/opentelemetry-js-contrib#1700 I guess this is why we want to have the option of not sending |
Discussed on January 18th System Semantic Conventions WG meeting, adding this as a blocker since it would potentially change attribute names |
Reading the constraint @open-telemetry/semconv-system-approvers what do you think? |
Discussed on February 22th System Semantic Conventions WG meeting, and we agree that it makes sense to do the alignment and add the constraint for |
What are you trying to achieve?
I've noticed these metrics are quite similar since they are measuring the same but process has a smaller scope. There is only a couple of differences.
Process metrics have no prefix in their attribute names
System metrics are using
system.cpu.state
&system.cpu.logical_number
and process is usingstate
as attribute nameSystem ref: system-metrics.md
Process ref: process-metrics.md
Process metrics have a constraint about labels whereas system metrics doesn't have it
What did you expect to see?
IMHO aligning the semantic conventions makes sense. I'd propose to make process metrics conventions closer to system metrics conventions by
state
attribute and becomingprocess.cpu.state
Additional context.
System metrics semconv had a recent change which added prefixes
#89
Maybe this something that is planned also fro process and hardware metrics? I could help on that
The text was updated successfully, but these errors were encountered: