Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging: review sampling_relevant attributes #432

Closed
lmolkova opened this issue Oct 20, 2023 · 0 comments · Fixed by #1169
Closed

Messaging: review sampling_relevant attributes #432

lmolkova opened this issue Oct 20, 2023 · 0 comments · Fixed by #1169
Assignees
@lmolkova
Labels
messaging-stability-blocker

Comments

@lmolkova
Copy link
Contributor

None of the messaging attributes are marked as sampling_relevant.

See https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1261/files#r1367104027
@lmolkova lmolkova moved this from V1 - Stable Semantics to Post-stability in Spec: Messaging Semantics Oct 20, 2023
@github-project-automation github-project-automation bot moved this to V1 - Stable Semantics in Spec: Messaging Semantics Oct 20, 2023
@lmolkova lmolkova moved this from Post-stability to V1 - Stable Semantics in Spec: Messaging Semantics Oct 20, 2023
@lmolkova lmolkova self-assigned this Oct 20, 2023
@lmolkova lmolkova mentioned this issue Oct 20, 2023
Merged
11 tasks
@github-actions github-actions bot added the Stale label Feb 11, 2024
@joaopgrassi joaopgrassi removed the Stale label Feb 14, 2024
@lmolkova lmolkova mentioned this issue Jun 20, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmolkova lmolkova

Labels
messaging-stability-blocker
Projects
Spec: Messaging Semantics
Status: V1 - Stable Semantics
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define sampling relevant attributes for messaging client spans lmolkova/semantic-conventions
4 participants
@jsuereth @lmolkova @joaopgrassi @pyohannes