Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should HTTP client metrics have url.scheme? #356

Closed
lmolkova opened this issue Sep 29, 2023 · 0 comments · Fixed by #357
Closed

Should HTTP client metrics have url.scheme? #356

lmolkova opened this issue Sep 29, 2023 · 0 comments · Fixed by #357
Assignees

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Sep 29, 2023

HTTP Client metrics do not have a scheme:

  • scheme may be useful to break traffic down by http/https
  • more importantly, we populate port based on scheme
  - ref: server.port
    requirement_level:
      conditionally_required: If not default (`80` for `http` scheme, `443` for `https`).

Populating port alone won't be sufficient since we still won't know the scheme used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants