Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FaaS metrics - Should we remove the faas.invocations metric? #234

Open
joaopgrassi opened this issue Aug 7, 2023 · 1 comment
Open

FaaS metrics - Should we remove the faas.invocations metric? #234

joaopgrassi opened this issue Aug 7, 2023 · 1 comment
Assignees
@jsuereth @joaopgrassi

Comments

@joaopgrassi
Copy link
Member

During #88 and as pointed out by @lmolkova in #86 (comment), the metric faas.invocations can be derived from the histogram count in faas.invoke_duration.

This raise the question if we even need this metric at all. This issue is to discuss it and decide what to do.
@joaopgrassi joaopgrassi self-assigned this Aug 7, 2023
@joaopgrassi joaopgrassi mentioned this issue Aug 7, 2023
Merged
@jviau
Copy link

jviau commented Feb 7, 2024

In the same vein, faas.errors and faas.timeouts can also be removed if we add an attribute to faas.invoke_duration to indicate error. We could use the same attribute as http: error.type, where when it is present and non-null it indicates an error. For faas.timeouts: error.type == 'timeout'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

@joaopgrassi joaopgrassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsuereth @jviau @joaopgrassi