[chore] Enbled make fix can fix table format #1699
Conversation
docs/attributes-registry/android.md
Outdated
| @@ -13,16 +13,16 @@ | |||
|
|
|||
| The Android platform on which the Android application is running. | |||
|
|
|||
| | Attribute | Type | Description | Examples | Stability | | |||
| |---|---|---|---|---| | |||
| | Attribute | Type | Description | Examples | Stability | | |||
There was a problem hiding this comment.
these files are auto-generated, we should not modify them (and I think whitespaces in jinja are too complicated to format them in this way)
There was a problem hiding this comment.
@lmolkova make fix-format will update the tables
Yes, we can discuss if we need |
as you can see it breaks other checks (registry validation). Personally, I don't see a benefit in format check in MD + yaml repo with MD and yaml lint checks. |
|
Thanks @lmolkova , with that, shall we remove both |
I don't use |
fwiw, the only thing I ever use is |
Signed-off-by: Guangya Liu <gyliu@ibm.com>
|
I think we discussed in some other PR/Issue that it would be good to start enforcing the line limit in markdown, but that's probably a bigger endeavor. For ex we would have to avoid modifying any part of the auto-generated content (tables etc). For now removing it sounds good to me. I also don't use it. |
Fixes #1692
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]