From 1845233fde0d09c2858ed1bbfc20cde92ca1530d Mon Sep 17 00:00:00 2001 From: marcsanmi Date: Fri, 16 Jun 2023 10:29:31 +0200 Subject: [PATCH] Apply suggestion --- semantic_conventions/resource/container.yaml | 2 +- specification/resource/semantic_conventions/container.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/semantic_conventions/resource/container.yaml b/semantic_conventions/resource/container.yaml index ecfe83cc78..fe07abdb95 100644 --- a/semantic_conventions/resource/container.yaml +++ b/semantic_conventions/resource/container.yaml @@ -37,7 +37,7 @@ groups: brief: > Runtime specific image identifier. Usually a hash algorithm followed by a UUID. note: - On docker, `image.id` corresponds to the `Image` field from the Docker container inspect [API](https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerInspect) endpoint. + On docker, `container.image.id` corresponds to the `Image` field from the Docker container inspect [API](https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerInspect) endpoint. examples: ['sha256:19c92d0a00d1b66d897bceaa7319bee0dd38a10a851c60bcec9474aa3f01e50f'] - id: command type: string diff --git a/specification/resource/semantic_conventions/container.md b/specification/resource/semantic_conventions/container.md index f51576c57c..eaaaa8555f 100644 --- a/specification/resource/semantic_conventions/container.md +++ b/specification/resource/semantic_conventions/container.md @@ -19,7 +19,7 @@ | `container.command_line` | string | The full command run by the container as a single string representing the full command. | `otelcontribcol --config config.yaml` | Conditionally Required: [2] | | `container.command_args` | string[] | All the command arguments (including the command/executable itself) run by the container. | `[otelcontribcol, --config, config.yaml]` | Conditionally Required: [2] | -**[1]:** On docker, `image.id` corresponds to the `Image` field from the Docker container inspect [API](https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerInspect) endpoint. +**[1]:** On docker, `container.image.id` corresponds to the `Image` field from the Docker container inspect [API](https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerInspect) endpoint. **[2]:** If using embedded credentials or sensitive data, it is recommended to remove them to prevent potential leakage.