From 04aefd4602ab16411c752471eef711e067d67ac7 Mon Sep 17 00:00:00 2001 From: Eric Mustin Date: Tue, 11 May 2021 22:48:29 -0400 Subject: [PATCH 1/4] Add memcached to db.system semantic conventions As we already use `memcached` to represent the `db.system` Memcached in opentelemetry-python, I believe we should add to the specification recommendation https://github.com/open-telemetry/opentelemetry-python-contrib/blob/e606542981580971af1bbecbf07671c39f799665/instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py#L160 --- specification/trace/semantic_conventions/database.md | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/trace/semantic_conventions/database.md b/specification/trace/semantic_conventions/database.md index 234797ffeb7..967ec95c852 100644 --- a/specification/trace/semantic_conventions/database.md +++ b/specification/trace/semantic_conventions/database.md @@ -106,6 +106,7 @@ Some database systems may allow a connection to switch to a different `db.user`, | `neo4j` | Neo4j | | `geode` | Apache Geode | | `elasticsearch` | Elasticsearch | +| `memcached` | Memcached | ### Notes and well-known identifiers for `db.system` From d7b1896eb8c50bd2f5d2d33cca636e29451f19fc Mon Sep 17 00:00:00 2001 From: ericmustin Date: Tue, 11 May 2021 23:01:30 -0400 Subject: [PATCH 2/4] update yaml to include memcache in db table --- semantic_conventions/trace/database.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/semantic_conventions/trace/database.yaml b/semantic_conventions/trace/database.yaml index 220500fac69..27b464fdad9 100644 --- a/semantic_conventions/trace/database.yaml +++ b/semantic_conventions/trace/database.yaml @@ -147,6 +147,9 @@ groups: - id: elasticsearch value: 'elasticsearch' brief: 'Elasticsearch' + - id: memcached + value: 'memcached' + brief: 'Memcached' - id: connection_string tag: connection-level type: string From 60a9b5f70e270c785e043759c018faa287093c2c Mon Sep 17 00:00:00 2001 From: ericmustin Date: Wed, 12 May 2021 09:26:43 -0400 Subject: [PATCH 3/4] add memcache change to changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8094a4cc996..939bea5c07c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,8 @@ release. - Add JSON RPC specific conventions ([#1643](https://github.com/open-telemetry/opentelemetry-specification/pull/1643)). +- Add Memcache to Database specific conventions ([#1689](https://github.com/open-telemetry/opentelemetry-specification/pull/1689)). + ### Compatibility ### OpenTelemetry Protocol From df47e4caac34e8d0e2603d3b909a627743af2b96 Mon Sep 17 00:00:00 2001 From: Armin Ruech Date: Mon, 17 May 2021 11:04:21 +0200 Subject: [PATCH 4/4] Fix entry in CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cac8a163f8d..8ca7c83a6d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,7 @@ release. - Add JSON RPC specific conventions ([#1643](https://github.com/open-telemetry/opentelemetry-specification/pull/1643)). -- Add Memcache to Database specific conventions ([#1689](https://github.com/open-telemetry/opentelemetry-specification/pull/1689)). +- Add Memcached to Database specific conventions ([#1689](https://github.com/open-telemetry/opentelemetry-specification/pull/1689)). ### Compatibility