Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable instrumentations can change produced telemetry for bugfixes #4005

Open
pellared opened this issue Apr 22, 2024 · 1 comment
Open

Stable instrumentations can change produced telemetry for bugfixes #4005

pellared opened this issue Apr 22, 2024 · 1 comment
Labels
triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor

Comments

@pellared
Copy link
Member

pellared commented Apr 22, 2024

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/telemetry-stability.md

Such instrumentations are prohibited from changing any produced telemetry.

and

After the moratorium is lifted, stable instrumentations are allowed to change the produced telemetry if all the following conditions are fulfilled:

  • The change is part of OpenTelemetry semantic conventions and is in a released version of the specification.
  • The change has a corresponding published OpenTelemetry Schema File that describes the change.
  • The produced telemetry correctly specifies the respective Schema URL.

I think it we should explicitly callout that changes related to bugfixes and security patches are allowed.

Related to:

CC @trask , @lmolkova , @CodeBlanch

@pellared
Copy link
Member Author

It might be closed because of open-telemetry/semantic-conventions#860 (comment)

However, it may be worth to make it more clear or change some wording as e.g.

Such instrumentations are prohibited from changing any produced telemetry

gives an impression that nothing can be changed.

@austinlparker austinlparker added the triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor label Apr 23, 2024
@austinlparker austinlparker moved this to Spec - Accepted in 🔭 Main Backlog Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor
Projects
Status: Spec - Accepted
Development

No branches or pull requests

2 participants