-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider pulling in more url.* fields from ECS as part of alignment #3405
Comments
Logs, metrics, and traces should share common attributes, but most of the attributes can only be applicable to logs given they're verbose, sometimes duplicate information, and require additional logic/resources to populate them. We should either bring attributes which are not used for traces/metrics as log-only attributes (initially) or make them opt-in by default. |
Some initial thoughts after discussing in HTTP semconv stability WG today:
|
@trask Thanks for creating this separate thread to discuss this! I think the above really depends a lot on how we see the semantic conventions, i.e. in a very concrete context / scope (such as HTTP spans) or rather generic and signal agnostic. I know it's quite a fundamental question / topic, but I feel discussing it would help ECS alignment efforts going forward. First of all, I think that one of the biggest values of the semantic conventions is the correlation of different data points and signals (especially with OTel, apart from tracing, expanding more and more into metrics, logs and other signals). So I fully agree with @tigrannajaryan 's comment, i.e. different signals (especially traces and logs) should share as many semantic conventions as possible (unless there are good reasons not to do, such as cardinality for metrics, etc.). Therefore, IMHO per default we should consider attributes and and their namespaces as signal agnostic (and rather do exceptions for attributes that should not apply to certain signals, such as metrics, or should apply only to a specific signal). For example, in your comment above:
This is reasonable when considering just HTTP spans as the scope. But, in some logging and security use cases mixing up Happy to discuss this topic in more detail! I like the proposal of using the |
Yes, sure they should be opt-in, no reason to make these additional attributes required. I maintain that we should aim for uniformness of conventions for logs and traces (exceptions from this need an explanation). Traces don't have to use these attributes, they are just optional attributes that can be used if the user choses so. |
we discussed in HTTP semconv WG meeting today:
I'm removing HTTP semconv stability blocker tag from this issue ( |
Consider pulling in some or all of:
url.domain
url.extension
url.fragment
url.original
url.password
url.port
url.registered_domain
url.subdomain
url.top_level_domain
url.username
Based on @AlexanderWert's #3355 (comment)
And @tigrannajaryan's #3355 (comment):
The text was updated successfully, but these errors were encountered: