Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Metrics - what if message size is not available to the application? #2976

Closed
reyang opened this issue Nov 22, 2022 · 2 comments · Fixed by #3158
Closed

HTTP Metrics - what if message size is not available to the application? #2976

reyang opened this issue Nov 22, 2022 · 2 comments · Fixed by #3158
Assignees
@trask
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory

Comments

@reyang
Copy link
Member

reyang commented Nov 22, 2022

The current semantic convention says:

image

HTTP Message is defined in RFC https://www.rfc-editor.org/rfc/rfc2616#section-4. Most application layer frameworks do not have access to the entire size (they would normally have access to Content-Length header or the actual size of the body).

Ask: clarify what should instrumentation authors do if they don't have access to HTTP Message.
@reyang reyang added spec:metrics Related to the specification/metrics directory area:semantic-conventions Related to semantic conventions labels Nov 22, 2022
@reyang reyang moved this to Blockers for HTTP semconv stability in Semantic Conventions + Instrumentation Stability WG Nov 22, 2022
@trask trask assigned trask and unassigned carlosalberto Jan 30, 2023
@trask trask moved this to Can be addressed after stability in Spec: HTTP Semantic Conventions Jan 31, 2023
@trask
Copy link
Member

trask commented Feb 1, 2023

@reyang is this resolved by #3158 marking this metric as optional?

@reyang
Copy link
Member Author

reyang commented Feb 1, 2023

@reyang is this resolved by #3158 marking this metric as optional?

Yes.

@trask trask mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trask trask

Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory
Projects
Spec: HTTP Semantic Conventions
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add http metrics yaml trask/opentelemetry-specification
4 participants
@trask @carlosalberto @arminru @reyang