Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should http.server.active_requests have a net.host.port attribute? #2822

Closed
mateuszrzeszutek opened this issue Sep 22, 2022 · 1 comment · Fixed by #3158
Closed

Should http.server.active_requests have a net.host.port attribute? #2822

mateuszrzeszutek opened this issue Sep 22, 2022 · 1 comment · Fixed by #3158
Assignees
@trask
Labels
[label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:metrics Related to the specification/metrics directory

Comments

@mateuszrzeszutek
Copy link
Member

What are you trying to achieve?

Currently, the http.server.active_requests metric only includes the net.host.name attribute; for some reason net.host.port was skipped there. Should we fix that discrepancy?

Additional context.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md#attributes
@mateuszrzeszutek mateuszrzeszutek added the spec:metrics Related to the specification/metrics directory label Sep 22, 2022
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Sep 22, 2022
Merged
@rbailey7210 rbailey7210 added the [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide label Sep 30, 2022
@rbailey7210
Copy link

Please discuss in upcoming spec sig meeting

@trask trask assigned trask and unassigned bogdandrutu Jan 30, 2023
@trask trask moved this to Can be addressed after stability in Spec: HTTP Semantic Conventions Jan 30, 2023
@trask trask mentioned this issue Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trask trask

Labels
[label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:metrics Related to the specification/metrics directory
Projects
Spec: HTTP Semantic Conventions
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add http metrics yaml trask/opentelemetry-specification
4 participants
@trask @bogdandrutu @rbailey7210 @mateuszrzeszutek