Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.target in client traces #2712

Closed
amoscatelli opened this issue Aug 5, 2022 · 2 comments
Closed

http.target in client traces #2712

amoscatelli opened this issue Aug 5, 2022 · 2 comments
Assignees
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@amoscatelli
Copy link

What are you trying to achieve?

I would like http.target to be added in client traces by spec (maybe replacing http.url)

Additional context.

(open-telemetry/opentelemetry-js#3147)

As already commented in the above issue I think http.target would be better than http.url .
Used in combination with deployment.environment can be used to fetch spans and span metrics in much cleaner way.

In general I am suggesting, at least, to send http.url splitted in http.host and http.target by the spec.

What do you think ?

@amoscatelli amoscatelli added the spec:trace Related to the specification/trace directory label Aug 5, 2022
@Oberon00
Copy link
Member

Oberon00 commented Aug 5, 2022

This removal was fully intentional, it used to be there before the very recent #2469

@lmolkova re-designed the HTTP semantic conventions with the goal to remove redundant ways of reporting the same information. I believe Node.js is the only technology where the primary interface to the HTTP client is first creating a connection with the host and then using only the target for requests to that host. So it does not seem worth it to make an exception that only makes it easier for Node.js, but makes processing the data more complicated for every backend.

As already commented in the above issue I think http.target would be better than http.url

How so?

Used in combination with deployment.environment can be used to fetch spans and span metrics in much cleaner way.

Can you elaborate? deployment.environment does not seem at all related here.

@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Aug 5, 2022
@rbailey7210 rbailey7210 added the [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide label Aug 12, 2022
@trask trask assigned lmolkova and unassigned carlosalberto Jan 30, 2023
@trask
Copy link
Member

trask commented Feb 6, 2023

Closing out as stale. Please add requested info if you are still interested in this issue and it can be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide semconv:HTTP spec:trace Related to the specification/trace directory
Projects
Development

No branches or pull requests

6 participants