Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Cassandra Attributes #1058

Closed
FrankSpitulski opened this issue Oct 5, 2020 · 2 comments · Fixed by #1217
Closed

Additional Cassandra Attributes #1058

FrankSpitulski opened this issue Oct 5, 2020 · 2 comments · Fixed by #1217
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@FrankSpitulski
Copy link
Contributor

What are you trying to achieve?
I'd like to define more cassandra attributes, as requested by @trask in open-telemetry/opentelemetry-java-instrumentation#1314 (comment)
Additionally, some of these tags may apply to other DBs as well.

What did you expect to see?

I expected to see more detailed information, including table name, query execution information, etc. Listed below.

  public static final String QUERY_PAGE_SIZE = "query.pageSize";
  public static final String QUERY_CL = "query.cl"; // consistency level
  public static final String DB_HOST_DC = "db.host.dc";
  public static final String DB_HOST_ID = "db.host.id";
  public static final String QUERY_SPECULATIVE_EXECUTION_COUNT = "query.speculativeExecutionCount";
  public static final String QUERY_IDEMPOTENCE = "query.idempotence";
  public static final String QUERY_TABLE = "query.table";

Additional context.

Add any other context about the problem here. If you followed an existing documentation, please share the link to it.

Some of these tags already exist in the opentracing cassandra instrumentation https://github.com/opentracing-contrib/java-cassandra-driver/blob/master/opentracing-cassandra-driver-3/src/main/java/io/opentracing/contrib/cassandra/TracingSession.java#L500

@FrankSpitulski FrankSpitulski added the spec:trace Related to the specification/trace directory label Oct 5, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Oct 6, 2020
@andrewhsu andrewhsu added the release:after-ga Not required before GA release, and not going to work on before GA label Oct 6, 2020
@trask
Copy link
Member

trask commented Oct 21, 2020

@open-telemetry/specs-approvers are new semantic attributes allowed-for-ga, or on hold until after-ga? thx

@arminru
Copy link
Member

arminru commented Oct 21, 2020

@trask If they don't extend existing conventions with required attributes but are either entirely new or only add optional attributes, they should be allowed-for-ga IMHO, since they won't produce any additional work for SIGs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
4 participants