From d7d857b0a80c205e0f4fb8b933a6106b11c3fd3f Mon Sep 17 00:00:00 2001
From: Ben B <bongartz@klimlive.de>
Date: Mon, 21 Nov 2022 19:31:32 +0100
Subject: [PATCH] add ibm cloud as a cloud provider (#2965)

---
 CHANGELOG.md                                         | 3 +++
 semantic_conventions/resource/cloud.yaml             | 7 +++++++
 specification/resource/semantic_conventions/cloud.md | 2 ++
 3 files changed, 12 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 97944bb6157..4ed1edd65cd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,9 @@ release.
 
 ### Semantic Conventions
 
+- Add IBM Cloud as a cloud provider.
+  ([#2965](https://github.com/open-telemetry/opentelemetry-specification/pull/2965))
+
 ### Compatibility
 
 ### OpenTelemetry Protocol
diff --git a/semantic_conventions/resource/cloud.yaml b/semantic_conventions/resource/cloud.yaml
index cf46a342a2d..78395e4cf47 100644
--- a/semantic_conventions/resource/cloud.yaml
+++ b/semantic_conventions/resource/cloud.yaml
@@ -21,9 +21,13 @@ groups:
             - id: 'gcp'
               value: 'gcp'
               brief: 'Google Cloud Platform'
+            - id: 'ibm_cloud'
+              value: 'ibm_cloud'
+              brief: 'IBM Cloud'
             - id: 'tencent_cloud'
               value: 'tencent_cloud'
               brief: 'Tencent Cloud'
+
         brief: >
           Name of the cloud provider.
       - id: account.id
@@ -110,6 +114,9 @@ groups:
             - id: gcp_app_engine
               value: 'gcp_app_engine'
               brief: Google Cloud App Engine (GAE)
+            - id: ibm_cloud_openshift
+              value: 'ibm_cloud_openshift'
+              brief: Red Hat OpenShift on IBM Cloud
             - id: tencent_cloud_cvm
               value: 'tencent_cloud_cvm'
               brief: Tencent Cloud Cloud Virtual Machine (CVM)
diff --git a/specification/resource/semantic_conventions/cloud.md b/specification/resource/semantic_conventions/cloud.md
index 68ce8c3c8c6..07e167e14d2 100644
--- a/specification/resource/semantic_conventions/cloud.md
+++ b/specification/resource/semantic_conventions/cloud.md
@@ -29,6 +29,7 @@
 | `aws` | Amazon Web Services |
 | `azure` | Microsoft Azure |
 | `gcp` | Google Cloud Platform |
+| `ibm_cloud` | IBM Cloud |
 | `tencent_cloud` | Tencent Cloud |
 
 `cloud.platform` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.
@@ -53,6 +54,7 @@
 | `gcp_kubernetes_engine` | Google Cloud Kubernetes Engine (GKE) |
 | `gcp_cloud_functions` | Google Cloud Functions (GCF) |
 | `gcp_app_engine` | Google Cloud App Engine (GAE) |
+| `ibm_cloud_openshift` | Red Hat OpenShift on IBM Cloud |
 | `tencent_cloud_cvm` | Tencent Cloud Cloud Virtual Machine (CVM) |
 | `tencent_cloud_eks` | Tencent Cloud Elastic Kubernetes Service (EKS) |
 | `tencent_cloud_scf` | Tencent Cloud Serverless Cloud Function (SCF) |