From 929f24080867c26125e8e80dec6939ea4448313b Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 6 Feb 2023 12:30:54 -0800 Subject: [PATCH] Fix link --- semantic_conventions/metrics/http.yaml | 21 +++++++++++++++++++ .../semantic_conventions/http-metrics.md | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/semantic_conventions/metrics/http.yaml b/semantic_conventions/metrics/http.yaml index 49b8cfd0da7..6d88aea06b1 100644 --- a/semantic_conventions/metrics/http.yaml +++ b/semantic_conventions/metrics/http.yaml @@ -13,6 +13,13 @@ groups: - ref: http.route requirement_level: conditionally_required: If and only if it's available + brief: > + The matched route (path template in the format used by the respective server framework). See note below + examples: ['/users/:userID?', '{controller}/{action}/{id?}'] + note: > + MUST NOT be populated when this is not supported by the HTTP server framework as the route attribute should have low-cardinality and the URI path can NOT substitute it. + + SHOULD include the [application root](../../trace/semantic_conventions/http.md#http-server-definitions) if there is one. - ref: http.status_code requirement_level: conditionally_required: If and only if one was received/sent. @@ -98,6 +105,13 @@ groups: - ref: http.route requirement_level: conditionally_required: If and only if it's available + brief: > + The matched route (path template in the format used by the respective server framework). See note below + examples: ['/users/:userID?', '{controller}/{action}/{id?}'] + note: > + MUST NOT be populated when this is not supported by the HTTP server framework as the route attribute should have low-cardinality and the URI path can NOT substitute it. + + SHOULD include the [application root](../../trace/semantic_conventions/http.md#http-server-definitions) if there is one. - ref: http.status_code requirement_level: conditionally_required: If and only if one was received/sent. @@ -144,6 +158,13 @@ groups: - ref: http.route requirement_level: conditionally_required: If and only if it's available + brief: > + The matched route (path template in the format used by the respective server framework). See note below + examples: ['/users/:userID?', '{controller}/{action}/{id?}'] + note: > + MUST NOT be populated when this is not supported by the HTTP server framework as the route attribute should have low-cardinality and the URI path can NOT substitute it. + + SHOULD include the [application root](../../trace/semantic_conventions/http.md#http-server-definitions) if there is one. - ref: http.status_code requirement_level: conditionally_required: If and only if one was received/sent. diff --git a/specification/metrics/semantic_conventions/http-metrics.md b/specification/metrics/semantic_conventions/http-metrics.md index 5a2a058b7f8..c3dd83a4b95 100644 --- a/specification/metrics/semantic_conventions/http-metrics.md +++ b/specification/metrics/semantic_conventions/http-metrics.md @@ -125,7 +125,7 @@ This metric is optional. **[1]:** If `net.transport` is not specified, it can be assumed to be `IP.TCP` except if `http.flavor` is `QUIC`, in which case `IP.UDP` is assumed. **[2]:** MUST NOT be populated when this is not supported by the HTTP server framework as the route attribute should have low-cardinality and the URI path can NOT substitute it. -SHOULD include the [application root](#http-server-definitions) if there is one. +SHOULD include the [application root](../../trace/semantic_conventions/http.md#http-server-definitions) if there is one. **[3]:** Determined by using the first of the following that applies